-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
263 go over smart contracts functions and review things #77
Merged
SamBorisov
merged 8 commits into
main
from
263-go-over-smart-contracts-functions-and-review-things
Nov 5, 2024
Merged
263 go over smart contracts functions and review things #77
SamBorisov
merged 8 commits into
main
from
263-go-over-smart-contracts-functions-and-review-things
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11680693806Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Vitomir2
requested changes
Oct 31, 2024
contracts/HydraDelegation/modules/DelegationPoolLib/DelegationPoolLib.sol
Outdated
Show resolved
Hide resolved
contracts/HydraDelegation/modules/DelegationPoolLib/DelegationPoolLib.sol
Outdated
Show resolved
Hide resolved
Vitomir2
approved these changes
Nov 1, 2024
R-Santev
requested changes
Nov 4, 2024
R-Santev
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polish contracts, do not change any logic.
Added comments in the ticket about the review and potential fixes!