Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

263 go over smart contracts functions and review things #77

Merged

Conversation

SamBorisov
Copy link
Contributor

Polish contracts, do not change any logic.
Added comments in the ticket about the review and potential fixes!

@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11680693806

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 79 of 83 (95.18%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.596%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/HydraDelegation/modules/DelegationPoolLib/DelegationPoolLib.sol 30 31 96.77%
contracts/HydraDelegation/modules/VestedDelegation/VestedDelegation.sol 0 1 0.0%
contracts/HydraStaking/modules/VestedStaking/VestedStaking.sol 13 14 92.86%
contracts/common/Vesting/Vesting.sol 2 3 66.67%
Totals Coverage Status
Change from base Build 11590313309: 0.1%
Covered Lines: 1198
Relevant Lines: 1278

💛 - Coveralls

@SamBorisov SamBorisov requested a review from Vitomir2 November 1, 2024 08:31
@SamBorisov SamBorisov requested a review from R-Santev November 4, 2024 15:39
@SamBorisov SamBorisov merged commit 52c7676 into main Nov 5, 2024
7 checks passed
@SamBorisov SamBorisov deleted the 263-go-over-smart-contracts-functions-and-review-things branch November 5, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants