76 150 validator spot limit #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create the Participation struct and the mapping for the validator's participation; create new status for active validator and activate it when initially stake; update the status check of the validator with active where applicable; set the activeFrom the current block number when activate the validator; create new function in the ValidatorSet interface to update the lastlyActive for the validator participation; update the unstaking to take into account the delegation when unstaking full amount; fix tests and write some new ones to cover the new changes;
R-Santev
requested changes
May 27, 2024
R-Santev
requested changes
May 28, 2024
| function getValidators() public view returns (address[] memory) { | ||
| return validatorsAddresses; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc IValidatorSet | ||
| */ | ||
| function getCurrentValidatorsCount() public view returns (uint256) { |
There was a problem hiding this comment.
Suggested change
| function getCurrentValidatorsCount() public view returns (uint256) { | |
| function getActiveValidatorsCount() public view returns (uint256) { |
test/ValidatorSet/Staking.test.ts
Outdated
| @@ -86,12 +86,25 @@ export function RunStakingTests(): void { | |||
| await expect(validatorSet.connect(this.signers.validators[0]).stake({ value: this.minStake })).to.not.be.reverted; | |||
| }); | |||
|
|
|||
| it("should get all active validators", async function () { | |||
There was a problem hiding this comment.
This is not a Staking function to be tested here and it doesn't return active validators
There was a problem hiding this comment.
Removed tests for in Staking for seeing all validators and active count
| @@ -301,14 +301,21 @@ describe("ValidatorSet", function () { | |||
| expect(currentEpochId, "currentEpochId").to.equal(2); | |||
| }); | |||
|
|
|||
| it("should get all active validators - admin", async function () { | |||
There was a problem hiding this comment.
This function doesn't get active validators.
R-Santev
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now having limit of 150 Validators