Remove lodash.get from apiRequest

HubSpot · Feb 25, 2025 · 83fd6e6 · 83fd6e6
1 parent 34f74df
commit 83fd6e6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/src/services/http/Auth.ts b/src/services/http/Auth.ts
@@ -1,4 +1,3 @@
-import get from 'lodash.get'
 import IConfiguration from '../../configuration/IConfiguration'
 import { AuthTypes } from './AuthTypes'
 import { IHttpOptions } from './IHttpOptions'
@@ -12,7 +11,7 @@ export class Auth {
       }
     } else {
       for (const key in AuthTypes) {
-        if (get(config, key)) {
+        if (config[key as keyof typeof AuthTypes]) {
           type = key
         }
       }

diff --git a/src/services/http/AuthTypes.ts b/src/services/http/AuthTypes.ts
@@ -1,7 +1,5 @@
-import { AuthMethods } from './AuthMethods'
-
 export enum AuthTypes {
-  apiKey = AuthMethods.hapikey,
-  accessToken = AuthMethods.accessToken,
-  developerApiKey = AuthMethods.hapikey,
+  apiKey = 'hapikey',
+  accessToken = 'accessToken',
+  developerApiKey = 'hapikey'
 }
diff --git a/src/services/http/Request.ts b/src/services/http/Request.ts
@@ -1,4 +1,3 @@
-import get from 'lodash.get'
 import { ApiClientConfigurator } from '../../configuration/ApiClientConfigurator'
 import IConfiguration from '../../configuration/IConfiguration'
 import { Auth } from './Auth'
@@ -54,9 +53,8 @@ export class Request {
 
     if (authType && authType in AuthTypes) {
       const type = authType as keyof typeof AuthTypes
-
-      const method: keyof typeof AuthMethods = AuthTypes[type]
-      const value = get(this.config, authType)
+      const method: string = AuthTypes[type]
+      const value: string = this.config[type] ?? ""
       if (method === AuthMethods.hapikey) {
         this.url.searchParams.set('hapikey', value)
       }