add DEFAULT_OBJECTS_LIMIT and after to getAll

HubSpot · Nov 3, 2021 · 6ad1752 · 6ad1752
1 parent 61ce7a1
commit 6ad1752
Show file tree

Hide file tree

Showing 9 changed files with 64 additions and 29 deletions.
diff --git a/.env.template b/.env.template
@@ -1 +1 @@
-HUBSPOT_API_KEY=
+HUBSPOT_API_KEY=
diff --git a/src/constants.ts b/src/constants.ts
@@ -0,0 +1 @@
+export const DEFAULT_OBJECTS_LIMIT = 100
diff --git a/src/discovery/crm/companies/CompaniesDiscovery.ts b/src/discovery/crm/companies/CompaniesDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/companies/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -29,24 +30,28 @@ export class CompaniesDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }
+
 }
diff --git a/src/discovery/crm/contacts/ContactsDiscovery.ts b/src/discovery/crm/contacts/ContactsDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/contacts/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -32,23 +33,26 @@ export class ContactsDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }

diff --git a/src/discovery/crm/deals/DealsDiscovery.ts b/src/discovery/crm/deals/DealsDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/deals/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -29,24 +30,28 @@ export class DealsDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }
+
 }
diff --git a/src/discovery/crm/line_items/LineItemsDiscovery.ts b/src/discovery/crm/line_items/LineItemsDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/line_items/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -29,24 +30,28 @@ export class LineItemsDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }
+
 }
diff --git a/src/discovery/crm/products/ProductsDiscovery.ts b/src/discovery/crm/products/ProductsDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/products/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -29,24 +30,28 @@ export class ProductsDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }
+
 }
diff --git a/src/discovery/crm/quotes/QuotesDiscovery.ts b/src/discovery/crm/quotes/QuotesDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/quotes/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -29,24 +30,28 @@ export class QuotesDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }
+
 }
diff --git a/src/discovery/crm/tickets/TicketsDiscovery.ts b/src/discovery/crm/tickets/TicketsDiscovery.ts
@@ -1,5 +1,6 @@
 import * as _ from 'lodash'
 import { createConfiguration } from '../../../../codegen/crm/tickets/configuration'
+import { DEFAULT_OBJECTS_LIMIT } from '../../../constants'
 import {
   AssociationsApi,
   BasicApi,
@@ -29,24 +30,28 @@ export class TicketsDiscovery extends BaseDiscovery {
   }
 
   public async getAll(
+    limit?: number,
+    after?: string,
     properties?: Array<string>,
     associations?: Array<string>,
     archived?: boolean,
   ): Promise<SimplePublicObjectWithAssociations[]> {
-    let after
+    const limitInternal = limit ?? DEFAULT_OBJECTS_LIMIT
+    let afterInternal = after
     let result: SimplePublicObjectWithAssociations[] = []
     do {
       let response: CollectionResponseSimplePublicObjectWithAssociationsForwardPaging = await this.basicApi.getPage(
-        100,
+        limitInternal,
         after,
         properties,
         associations,
         archived,
       )
       result = result.concat(response.results)
-      after = _.get(response, 'paging.next.after')
-    } while (!_.isNil(after))
+      afterInternal = _.get(response, 'paging.next.after')
+    } while (!_.isNil(afterInternal))
 
     return result
   }
+
 }