Fix #416 : Prevent nvmlShutdown from being called when uninitialized #417
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alized Problem: `check_nvidia_gpu()` crashes with `pynvml.NVMLError_Uninitialized` if NVIDIA GPU is not detected or drivers are missing. This happens because `pynvml.nvmlShutdown()` is called in the `finally` block even if `pynvml.nvmlInit()` failed. Cause: `pynvml.nvmlShutdown()` must only be called after successful `pynvml.nvmlInit()`. When `nvmlInit()` fails, the library is uninitialized, and calling `nvmlShutdown()` leads to the error. The `finally` block unconditionally executes `nvmlShutdown()`. Solution: Introduce an `initialized` flag. Set it to `True` after successful `pynvml.nvmlInit()`. Conditionally call `pynvml.nvmlShutdown()` in the `finally` block only when `initialized` is `True`. Impact: Prevents crash when NVIDIA GPU is not detected or drivers are missing. Improves error handling and robustness. No new tests needed as it fixes error flow.
Before:
After:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #416 : Prevent nvmlShutdown from being called when uninitialized
Problem:
check_nvidia_gpu()crashes withpynvml.NVMLError_Uninitializedif NVIDIA GPU is not detected or drivers are missing. This happens becausepynvml.nvmlShutdown()is called in thefinallyblock even ifpynvml.nvmlInit()failed.Cause:
pynvml.nvmlShutdown()must only be called after successfulpynvml.nvmlInit(). WhennvmlInit()fails, the library is uninitialized, and callingnvmlShutdown()leads to the error. Thefinallyblock unconditionally executesnvmlShutdown().Solution:
Introduce an
initializedflag. Set it toTrueafter successfulpynvml.nvmlInit(). Conditionally callpynvml.nvmlShutdown()in thefinallyblock only wheninitializedisTrue.Impact:
Prevents crash when NVIDIA GPU is not detected or drivers are missing. Improves error handling and robustness.
No new tests needed as it fixes error flow.