Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency versions #1315

Closed
wants to merge 2 commits into from
Closed

Bump dependency versions #1315

wants to merge 2 commits into from

Conversation

SeppahBaws
Copy link
Collaborator

Bumps dependency versions:

  • vite -> v5
  • svelte -> v4
  • sveltekit -> v2

Something is still broken atm, but I'm not even sure how to fix it but hopefully I will soon™️
css-tree is a dependency of Svelte, but somehow after the upgrades it is getting included in the houdini-plugin-svelte-global-stores output, which causes this issue.

Ideas on how to fix this are more than welcome 🙃

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: a58ca3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit a58ca3f
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/6686b9e013a15300082fc423

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit a58ca3f
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/6686b9e0602ebb000864a3f5

@SeppahBaws
Copy link
Collaborator Author

Ok I'm going to close this as it would be too much of a hassle to get this working correctly. I think the only fix for the css-tree problem is upgrading to svelte 5, but that's already being solved in #1300

@SeppahBaws SeppahBaws closed this Aug 5, 2024
@SeppahBaws SeppahBaws deleted the bump-dependency-versions branch August 5, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant