Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade javassist to 3.30.2-GA #626

Merged

Conversation

binfeiruci
Copy link

@skybber
Copy link
Contributor

skybber commented Jan 14, 2025

Thank you, I still need to test whether you have included our modifications to the original Javassist.

@skybber skybber merged commit 7c57e2e into HotswapProjects:master Jan 14, 2025
@skybber
Copy link
Contributor

skybber commented Jan 14, 2025

Unfortunately, I had to roll back your changes because they did not include the Javassist modifications used by HotswapAgent. The fix should correctly consist of two commits:

  • Commit (1): The new version of Javassist without any modifications.
  • Commit (2): Changes related solely to HotswapAgent.

@binfeiruci
Copy link
Author

oops, I forgot to check the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants