Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring and general improvements #560

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

HotCakeX
Copy link
Owner

  • Refactored lots of codes to be more optimized and use less lines of code.
  • Improved the icons in the supplemental policy creation and policy creation pages.
  • The Create policy page's deploy buttons are now consistent with the rest of the deploy buttons in the app.
  • Improved consistency in the codebase and UI elements.
  • Improved log messages.
  • Removed 2 unused methods.
  • Reduced the number of empty lines in XAML and C# files.
  • Removed unused declarations in the XAML pages.
  • Improved the comments in the code to be clearer and more accurate.
  • Added sidebar support to the PFN based and Strict kernel-mode supplemental policy creation sections.
  • Removed the static color for text highlights in flyout text boxes. The colors are now dynamically set based on the Windows accent color.
  • The "Get Configuration" button in the Settings page now automatically expands the section to make the configurations visible, reducing extra clicks/taps needed.

* Refactored lots of codes to be more optimized and use less lines of code.
* Improved the icons in the supplemental policy creation and policy creation pages.
* The Create policy page's deploy buttons are now consistent with the rest of the deploy buttons in the app.
* Improved consistency in the codebase and UI elements.
* Improved log messages.
* Removed 2 unused methods.
* Reduced the number of empty lines in XAML and C# files.
* Removed unused declarations in the XAML pages.
* Improved the comments in the code to be clearer and more accurate.
* Added sidebar support to the PFN based and Strict kernel-mode supplemental policy creation sections.
* Removed the static color for text highlights in flyout text boxes. The colors are now dynamically set based on the Windows accent color.
* The "Get Configuration" button in the Settings page now automatically expands the section to make the configurations visible, reducing extra clicks/taps needed.
@HotCakeX HotCakeX added the Enhancement 💯 New feature or request label Jan 23, 2025
@HotCakeX HotCakeX self-assigned this Jan 23, 2025
@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 10:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 86 out of 101 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • AppControl Manager/CustomUIElements/SigningDetailsDialogForRemoval.xaml: Language not supported
  • AppControl Manager/MainWindow.xaml: Language not supported
  • AppControl Manager/IntelGathering/KernelUserVerdict.cs: Evaluated as low risk
  • AppControl Manager/IntelGathering/LocalFilesScan.cs: Evaluated as low risk
  • AppControl Manager/Main/BasePolicyCreator.cs: Evaluated as low risk
  • AppControl Manager/IntelGathering/FileIdentityOrigin.cs: Evaluated as low risk
  • AppControl Manager/IntelGathering/GetMDEAdvancedHuntingLogsData.cs: Evaluated as low risk
  • AppControl Manager/IntelGathering/KernelModeDrivers.cs: Evaluated as low risk
  • AppControl Manager/IntelGathering/EventAction.cs: Evaluated as low risk
  • AppControl Manager/Others/AllCertificatesGrabber.cs: Evaluated as low risk
  • AppControl Manager/Others/CiToolHelper.cs: Evaluated as low risk
  • AppControl Manager/Main/SetCiRuleOptions.cs: Evaluated as low risk
  • AppControl Manager/CustomUIElements/SigningDetailsDialogForRemoval.xaml.cs: Evaluated as low risk
  • AppControl Manager/MainWindow.xaml.cs: Evaluated as low risk
  • AppControl Manager/IntelGathering/GetEventLogsData.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

AppControl Manager/Main/UserConfiguration.cs:37

  • The log message should be moved after the file write operation to ensure accuracy.
Logger.Write("The UserConfigurations.json file has been updated successfully.");

AppControl Manager/CustomUIElements/SigningDetailsDialog.xaml.cs:282

  • Consider adding a null check for the 'message' parameter to avoid potential issues.
private void ShowTeachingTip(string message)
@HotCakeX HotCakeX merged commit f473f7e into main Jan 23, 2025
2 checks passed
@HotCakeX HotCakeX deleted the Code-refactoring-and-general-improvements branch January 23, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💯 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant