Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented online file reputation verification in the Harden Windows Security moulde #507

Conversation

HotCakeX
Copy link
Owner

@HotCakeX HotCakeX commented Jan 6, 2025

  • Using Microsoft Defender, queries a file's reputation based on either the Smart App Control or SmartScreen, depending on whichever is in control. It doesn't need Admin privileges. It's in a new dedicated tab available in the GUI. Simply browse for a file and detect its reputation and some other advanced details.

  • Added description texts to the top of ASR rules, Optional features | Apps and the new tab for file reputations.

Using Microsoft Defender, queries a file's reputation based on either the Smart App Control or SmartScreen, depending on whichever is in control.
@HotCakeX HotCakeX added the Enhancement 💯 New feature or request label Jan 6, 2025
@HotCakeX HotCakeX self-assigned this Jan 6, 2025
@Copilot Copilot bot review requested due to automatic review settings January 6, 2025 13:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • Harden-Windows-Security Module/Harden Windows Security.csproj: Language not supported
  • Harden-Windows-Security Module/Main files/Resources/XAML/ASRRules.xaml: Language not supported
  • Harden-Windows-Security Module/Main files/Resources/XAML/FileReputation.xaml: Language not supported
  • Harden-Windows-Security Module/Main files/Resources/XAML/Main.xaml: Language not supported
  • Harden-Windows-Security Module/Main files/Resources/XAML/OptionalFeatures.xaml: Language not supported
  • Harden-Windows-Security Module/Main files/Resources/XAML/Protect.xaml: Language not supported
  • Harden-Windows-Security Module/Main files/C#/GUI/FileReputation/View.cs: Evaluated as low risk
  • Harden-Windows-Security Module/Main files/C#/Others/Initializer.cs: Evaluated as low risk
Comments suppressed due to low confidence (4)

Harden-Windows-Security Module/Main files/C#/Others/FileTrustChecker.cs:12

  • The defenderPath variable should be checked to ensure that the MpClient.dll file exists before attempting to load it.
private static readonly string defenderPath = Path.Combine(

Harden-Windows-Security Module/Main files/C#/Others/FileTrustChecker.cs:22

  • The CheckFileTrust method should have more comprehensive test coverage to ensure that it handles various scenarios correctly.
internal static FileTrustResult CheckFileTrust(string filePath)

Harden-Windows-Security Module/Main files/C#/GUI/OptionalFeatures/View.cs:35

  • The comment should start with a capital letter: 'If admin privileges are not available, return and do not proceed any further'.
// if Admin privileges are not available, return and do not proceed any further

Harden-Windows-Security Module/Main files/C#/GUI/Main/GUI.cs:150

  • The _viewCache should be initialized as a dictionary, not an array. Change it to: private readonly Dictionary<string, object> _viewCache = new Dictionary<string, object>();
private readonly Dictionary<string, object> _viewCache = [];
@HotCakeX HotCakeX merged commit 78aafb3 into main Jan 6, 2025
2 checks passed
@HotCakeX HotCakeX deleted the Implemented-file-reputation-check-based-on-Microsoft-Defender-features branch January 6, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💯 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant