Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] DeviceToken Entity + Save Logic #84

Merged
merged 7 commits into from
Dec 29, 2023
Merged

[FEAT] DeviceToken Entity + Save Logic #84

merged 7 commits into from
Dec 29, 2023

Conversation

jinjoo-lab
Copy link
Collaborator

@jinjoo-lab jinjoo-lab commented Dec 27, 2023 •
edited by ohksj77
Loading

추가/수정한 기능 설명

  1. DeviceToken Entity 추가
  2. Member랑 OneToOne
  3. SaveLogic

특이사항

DeviceToken이 초기화(재생성)되는 시점이 애매함 (백업 + 부팅) 이라는데 회원가입 + 로그인 로직에서 추가하기에는 무리가 있어서 따로 뺌

Device Token을 하나의 엔티티로 빼서 관리가 필요해보임

check list

  • 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했나요?
  • 추가/수정사항을 설명했나요?

@jinjoo-lab jinjoo-lab requested a review from ohksj77 December 27, 2023 08:39
ohksj77
ohksj77 reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. DeviceToken을 멤버 저장시에 저장할 수 없는 로직인지
  2. AuthService와 AuthController에 들어가는게 맞는지

에 대해 어떻게 생각하는지 궁금!

@ohksj77 ohksj77 added the feat 기능 추가 label Dec 29, 2023
@ohksj77 ohksj77 merged commit f741f5a into master Dec 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohksj77 ohksj77 ohksj77 approved these changes

Assignees

@jinjoo-lab jinjoo-lab

@ohksj77 ohksj77

Labels
feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinjoo-lab @ohksj77