Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] member test #64

Merged
merged 4 commits into from
Nov 20, 2023
Merged

[FEAT] member test #64

merged 4 commits into from
Nov 20, 2023

Conversation

jinjoo-lab
Copy link
Collaborator

@jinjoo-lab jinjoo-lab commented Nov 15, 2023

추가/수정한 기능 설명

  1. memberRepositoryTest : 저장 + softDelete

특이사항

check list

  • 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했나요?
  • 추가/수정사항을 설명했나요?

@jinjoo-lab jinjoo-lab requested a review from ohksj77 November 15, 2023 01:41
@ohksj77 ohksj77 changed the title [FEAT] Feat/member test [FEAT] member test Nov 15, 2023
@ohksj77 ohksj77 added the test 테스트 수행 label Nov 15, 2023
Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검증 과정에 대한 코멘트 읽어줘!
지금 상태로는 저 boolean 값이 false여도 테스트는 통과할거 같아

Copy link
Member

@ohksj77 ohksj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳

// when
DuplicateNicknameResponse response = memberService.duplicateNickname(member.getNickname());
// then
assertTrue(response.getIsPresent());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertThat(~~).isTrue(); 와 같은 API도 있는데 이건 assertj 꺼라서 통일성을 주려면 이게 더 좋을 것 같아!

@jinjoo-lab jinjoo-lab merged commit 2d7e0e1 into master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test 테스트 수행
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants