Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luarocks: add test for [email protected] and luajit #66287

Closed
wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 5, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Follows up #65993

This PR commits a test-only change, so probably doesn't need to pass CI (though it does on 11.0 and 10.14. Catalina nodes are being weird atm).

@BrewTestBot BrewTestBot added the lua Lua use is a significant feature of the PR or issue label Dec 5, 2020
@carlocab
Copy link
Member Author

carlocab commented Dec 5, 2020

10.15 error:

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

@carlocab
Copy link
Member Author

carlocab commented Dec 5, 2020

10.14 succeeds, but 10.15 build error:

==> brew uninstall --force lua [email protected] [email protected]
Error: No available formula with the name "vv".
Error: Process completed with exit code 1.

I get this error even if I just give luarocks a revision bump (826764a): https://github.com/Homebrew/homebrew-core/runs/1504433319

NoSome idea of what's going on:

❯ brew uses --include-build --include-test --recursive luarocks
corsixth        lmod            neovim          sile            vis             vv
❯ brew info vv
vv: 2.3.0
https://github.com/vv-vim/vv
Not installed
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/vv.rb
...

CI wants to test vv because it's reported as depending on luarocks through neovim. However, vv is a cask, so won't work with brew install --formula. See #66268.

@carlocab carlocab force-pushed the luarocks-test branch 2 times, most recently from c5e999e to 3b711bb Compare December 5, 2020 19:58
@carlocab carlocab marked this pull request as draft December 5, 2020 20:18
@carlocab carlocab mentioned this pull request Dec 5, 2020
5 tasks
@carlocab carlocab marked this pull request as ready for review December 5, 2020 20:38
@carlocab carlocab force-pushed the luarocks-test branch 2 times, most recently from 77e7c2e to c8c2f8c Compare December 5, 2020 23:27
@carlocab carlocab changed the title luarocks: add test for [email protected] luarocks: add test for [email protected] and luajit Dec 5, 2020
@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@carlocab carlocab deleted the luarocks-test branch December 7, 2020 00:27
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 6, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants