-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua 5.4.1 #65993
Closed
Closed
Lua 5.4.1 #65993
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e8cf4da
lua 5.4.1
carlocab b3a5730
Rename `[email protected]` alias
carlocab 7bbf9cc
Add [email protected]
carlocab 327a828
Remove renamed formula
carlocab 9e3b9e6
clingo revision bump (lua 5.4.1)
carlocab e77d267
corsixth revision bump (lua 5.4.1)
carlocab ccceb8d
freeswitch revision bump (lua 5.4.1)
carlocab f6f7acb
gnuplot revision bump (lua 5.4.1)
carlocab c5cfc99
highlight revision bump (lua 5.4.1)
carlocab 37ef9fe
imapfilter revision bump (lua 5.4.1)
carlocab bfbb8f3
instead revision bump (lua 5.4.1)
carlocab dd254ee
kyua revision bump (lua 5.4.1)
carlocab ae2af8c
lcm revision bump (lua 5.4.1)
carlocab e80d2c9
lsyncd revision bump (lua 5.4.1)
carlocab 7c73af2
lutok revision bump (lua 5.4.1)
carlocab beeb261
macvim revision bump (lua 5.4.1)
carlocab 12f9bd4
neomutt revision bump (lua 5.4.1)
carlocab 405b0cd
onscripter revision bump (lua 5.4.1)
carlocab 078ce34
osrm-backend revision bump (lua 5.4.1)
carlocab 5668497
pdns revision bump (lua 5.4.1)
carlocab 800721b
pdnsrec revision bump (lua 5.4.1)
carlocab df74ea8
rpm revision bump (lua 5.4.1)
carlocab 21e8c79
sile revision bump (lua 5.4.1)
carlocab f8afe31
tracebox revision bump (lua 5.4.1)
carlocab c484133
vim revision bump (lua 5.4.1)
carlocab f8119b0
vis revision bump (lua 5.4.1)
carlocab 54b5098
weechat revision bump (lua 5.4.1)
carlocab 28cb03d
luarocks: fix test + revision bump (lua 5.4.1)
carlocab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ class Corsixth < Formula | |
url "https://github.com/CorsixTH/CorsixTH/archive/v0.64.tar.gz" | ||
sha256 "12389a95de0031baec1a3fc77208d44228177f49564f1c79ae763ab4aeeafa98" | ||
license "MIT" | ||
revision 1 | ||
head "https://github.com/CorsixTH/CorsixTH.git" | ||
|
||
bottle do | ||
|
@@ -18,7 +19,13 @@ class Corsixth < Formula | |
depends_on xcode: :build | ||
depends_on "ffmpeg" | ||
depends_on "freetype" | ||
depends_on "lua" | ||
|
||
# This PR implements a limited form of lua 5.4 support: | ||
# https://github.com/CorsixTH/CorsixTH/pull/1686 | ||
# It breaks some features. Maintainer does not appear to have intentions of | ||
# supporting lua 5.4. | ||
depends_on "[email protected]" | ||
|
||
depends_on "sdl2" | ||
depends_on "sdl2_mixer" | ||
|
||
|
@@ -34,6 +41,9 @@ class Corsixth < Formula | |
end | ||
|
||
def install | ||
# Make sure I point to the right version! | ||
lua = Formula["[email protected]"] | ||
|
||
ENV["TARGET_BUILD_DIR"] = "." | ||
ENV["FULL_PRODUCT_NAME"] = "CorsixTH.app" | ||
|
||
|
@@ -47,9 +57,9 @@ def install | |
end | ||
end | ||
|
||
system "cmake", ".", "-DLUA_INCLUDE_DIR=#{Formula["lua"].opt_include}/lua", | ||
"-DLUA_LIBRARY=#{Formula["lua"].opt_lib}/liblua.dylib", | ||
"-DLUA_PROGRAM_PATH=#{Formula["lua"].opt_bin}/lua", | ||
system "cmake", ".", "-DLUA_INCLUDE_DIR=#{lua.opt_include}/lua", | ||
"-DLUA_LIBRARY=#{lua.opt_lib}/liblua.dylib", | ||
"-DLUA_PROGRAM_PATH=#{lua.opt_bin}/lua", | ||
"-DCORSIX_TH_DATADIR=#{prefix}/CorsixTH.app/Contents/Resources/", | ||
*std_cmake_args | ||
system "make" | ||
|
@@ -62,8 +72,11 @@ def install | |
end | ||
|
||
test do | ||
# Make sure I point to the right version! | ||
lua = Formula["[email protected]"] | ||
|
||
app = prefix/"CorsixTH.app/Contents/MacOS/CorsixTH" | ||
assert_includes MachO::Tools.dylibs(app), | ||
"#{Formula["lua"].opt_lib}/liblua.5.3.dylib" | ||
"#{lua.opt_lib}/liblua.#{lua.version.major_minor}.dylib" | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ class Instead < Formula | |
url "https://github.com/instead-hub/instead/archive/3.3.2.tar.gz" | ||
sha256 "bdb827f36e693dc7b443e69d4678d24f1ccc20dc093c22f58b8d78192da15f2e" | ||
license "MIT" | ||
revision 1 | ||
|
||
bottle do | ||
sha256 "4279441d1a315d876f9646a284ac3beefd109e7fa7c4ebce2fb8549bf0947d94" => :big_sur | ||
|
@@ -13,17 +14,27 @@ class Instead < Formula | |
end | ||
|
||
depends_on "cmake" => :build | ||
depends_on "lua" | ||
|
||
# Possible patch for lua 5.4 support: | ||
# https://github.com/instead-hub/instead/commit/ea4f0e81c6859b0aadde582f47ffd7850f54a264 | ||
# Alternatively, this dependency may be replaced with luajit, which is the | ||
# package's preferred version of lua: | ||
# https://github.com/instead-hub/instead/blob/master/INSTALL | ||
depends_on "[email protected]" | ||
|
||
depends_on "sdl2" | ||
depends_on "sdl2_image" | ||
depends_on "sdl2_mixer" | ||
depends_on "sdl2_ttf" | ||
|
||
def install | ||
# Make sure I point to the correct lua version! | ||
lua = Formula["[email protected]"] | ||
|
||
mkdir "build" do | ||
system "cmake", "..", "-DWITH_GTK2=OFF", | ||
"-DLUA_INCLUDE_DIR=#{Formula["lua"].opt_include}/lua", | ||
"-DLUA_LIBRARY=#{Formula["lua"].opt_lib}/liblua.dylib", | ||
"-DLUA_INCLUDE_DIR=#{lua.opt_include}/lua", | ||
"-DLUA_LIBRARY=#{lua.opt_lib}/liblua.dylib", | ||
*std_cmake_args | ||
system "make", "install" | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ class Lsyncd < Formula | |
url "https://github.com/axkibe/lsyncd/archive/release-2.2.3.tar.gz" | ||
sha256 "7bcd0f4ae126040bb078c482ff856c87e61c22472c23fa3071798dcb1dc388dd" | ||
license "GPL-2.0" | ||
revision 1 | ||
|
||
bottle do | ||
cellar :any | ||
|
@@ -15,7 +16,10 @@ class Lsyncd < Formula | |
end | ||
|
||
depends_on "cmake" => :build | ||
depends_on "lua" | ||
|
||
# lua 5.4 support tracking issue: | ||
# https://github.com/axkibe/lsyncd/issues/621 | ||
depends_on "[email protected]" | ||
|
||
xnu_headers = { | ||
"10.7" => ["xnu-1699.22.73.tar.gz", "c9d24560af543e6099b6248bdbcef3581e7ba4af3afd92974719f7c5a8db5bd2"], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this patch will be around for a while, is it submitted upstream already? And/or can we migrate it to Homebrew/formula-patches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch has been around for quite a while: Homebrew/legacy-homebrew#5043
I think it's somewhat unique to the way Homebrew packages things? Though I don't see how it could hurt upstream, and probably only helps.
I don't mind migrating it to Homebrew/formula-patches. Do you mind if I pursue that in a separate PR, if (fingers crossed) this one gets merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only just realised exactly how old this patch is. It's really alarming.
I'm going to try to see if I can track down someone familiar with lua internals who can have a look at the patch.