Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvc: use llvm as runtime dependency #54741

Closed
wants to merge 1 commit into from
Closed

nvc: use llvm as runtime dependency #54741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions Formula/nvc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
class Nvc < Formula
desc "VHDL compiler and simulator"
homepage "https://github.com/nickg/nvc"
url "https://github.com/nickg/nvc/releases/download/r1.4.0/nvc-1.4.0.tar.gz"
sha256 "1a874bde284408c137a93b22f8f12b5b8c3368cefe30f3a5458ccdeffa0c6ad6"
revision 1

stable do
url "https://github.com/nickg/nvc/releases/download/r1.4.0/nvc-1.4.0.tar.gz"
sha256 "1a874bde284408c137a93b22f8f12b5b8c3368cefe30f3a5458ccdeffa0c6ad6"
# Upstream issue, only fix on master branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a short summary of what this patch is fixing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in b868043

# at the end of installation, nvc tries to donwload from IEEE,
# however the IEEE website changes the download path
# this patch fixes this issue
patch do
url "https://github.com/nickg/nvc/commit/db4565c33f7effcab4c8b886d664398a85b653f6.patch?full_index=1"
sha256 "41a7de8c78730cbf674246abdc3e824ba26723db963536cb019ed9deb77dc0a3"
end
end

bottle do
sha256 "b80db7d1bf860cf294e21504ca5016949379eb09f5e91f2ada221f7c93e0a470" => :mojave
Expand All @@ -19,8 +31,10 @@ class Nvc < Formula
end

depends_on "check" => :build
depends_on "llvm" => :build
depends_on "pkg-config" => :build
# llvm 8+ is not supported https://github.com/nickg/nvc/commit/c3d1ae5700cfba6070293ad1bb5a6c198c631195
# and llvm 7 has issue on stable https://github.com/nickg/nvc/commit/dfd5606a182e00d5f7a9e28902234b374c7b2863
depends_on "llvm@6"
Comment on lines +35 to +37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a patch from nickg/nvc@dfd5606 and use llvm@7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can try it

Copy link
Contributor Author

@jnozsc jnozsc May 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch does not seem work https://github.com/Homebrew/homebrew-core/runs/685654208. that's why I had to use llvm@6. lmk any thought

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump. any thought?


resource "vim-hdl-examples" do
url "https://github.com/suoto/vim-hdl-examples.git",
Expand All @@ -30,7 +44,7 @@ class Nvc < Formula
def install
system "./autogen.sh" if build.head?
system "./tools/fetch-ieee.sh"
system "./configure", "--with-llvm=#{Formula["llvm"].opt_bin}/llvm-config",
system "./configure", "--with-llvm=#{Formula["llvm@6"].opt_bin}/llvm-config",
"--prefix=#{prefix}",
"--with-system-cc=/usr/bin/clang"
system "make"
Expand Down