Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discodex: audit fixes #210

Closed
wants to merge 1 commit into from
Closed

discodex: audit fixes #210

wants to merge 1 commit into from

Conversation

nijikon
Copy link
Contributor

@nijikon nijikon commented Apr 11, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Does your submission pass brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • Have you built your formula locally prior to submission with brew install <formula>?

@nijikon
Copy link
Contributor Author

nijikon commented Apr 11, 2016

🍼

@nijikon
Copy link
Contributor Author

nijikon commented Apr 11, 2016

@BrewTestBot test this please

@DomT4
Copy link
Contributor

DomT4 commented Apr 11, 2016

Welp, It's doing remote code fetching in make:

Pulling lager from {git,"https://github.com/basho/lager.git",{tag,"2.0.3"}}
Cloning into 'lager'...
Pulling folsomite from {git,"https://github.com/discoproject/folsomite",
                            {branch,"master"}}
Cloning into 'folsomite'...
Pulling plists from {git,"https://github.com/discoproject/plists",
                         {branch,"master"}}
Cloning into 'plists'...
Pulling mochiweb from {git,"https://github.com/mochi/mochiweb.git",
                           {tag,"v2.9.2"}}
Cloning into 'mochiweb'...
WARN:  Expected /private/tmp/disco20160411-65021-psbmwp/disco-0.5.4/master/deps/goldrush to be an app dir (containing ebin/*.app), but no .app found.
==> lager (get-deps)
WARN:  Expected /private/tmp/disco20160411-65021-psbmwp/disco-0.5.4/master/deps/goldrush to be an app dir (containing ebin/*.app), but no .app found.
Pulling goldrush from {git,"git://github.com/DeadZen/goldrush.git",
                           {tag,"0.1.6"}}

There's no tagged release upstream, no upstream commits in years, @apjanke filed an Issue three years ago asking for a tag with no reply and there have been no bottled downloads in 365 days.

Maybe this is worth just boneyarding.

@nijikon
Copy link
Contributor Author

nijikon commented Apr 11, 2016

I thought about it :)

@nijikon
Copy link
Contributor Author

nijikon commented Apr 11, 2016

All in favor of removing this 👍

@DomT4 DomT4 added the marked for removal/rejection PR is probably going to be closed or formula deleted label Apr 11, 2016
@DomT4
Copy link
Contributor

DomT4 commented Apr 11, 2016

Feel free to change the PR to do that :)

@MikeMcQuaid
Copy link
Member

👍 to boneyard

@apjanke
Copy link
Contributor

apjanke commented Apr 11, 2016

Yeah, boneyard.

@apjanke
Copy link
Contributor

apjanke commented Apr 13, 2016

@nijikon nijikon closed this Apr 13, 2016
@nijikon nijikon deleted the discodex branch April 13, 2016 08:18
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
marked for removal/rejection PR is probably going to be closed or formula deleted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants