Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cjdns 22.1 #203576

Merged
merged 2 commits into from
Jan 8, 2025
Merged

cjdns 22.1 #203576

merged 2 commits into from
Jan 8, 2025

Conversation

cjdelisle
Copy link
Contributor

@cjdelisle cjdelisle commented Jan 8, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

remove workarounds which should be no longer necessary, add cjdnstool

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. nodejs Node or npm use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Jan 8, 2025
@cjdelisle
Copy link
Contributor Author

Hey I noticed that you guys were keeping this up to date without me. I specifically want to say thank you to @ZhongRuoyu and @chenrui333 and whoever else has helped out with this. I'll be at FOSDEM so hope to see you there !

Remove no-longer-needed workarounds
Add cjdnstool binary which is now part of cjdns
@alebcay alebcay force-pushed the cjdns-v22.1-tested branch from 1f11403 to a82dec7 Compare January 8, 2025 15:30
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 8, 2025
@alebcay
Copy link
Member

alebcay commented Jan 8, 2025

Thanks for the contribution! Just amended the commit message to match the expected style.

@cjdelisle
Copy link
Contributor Author

Thank you, I tried to follow it but I guess I had one too many newlines.

@stefanb stefanb changed the title Update cjdns to v22.1, remove workarounds which should be no longer necessary, add cjdnstool cjdns 22.1 Jan 8, 2025
@stefanb
Copy link
Member

stefanb commented Jan 8, 2025

Shortened PR title, moved extra description from PR title to PR body

Copy link
Contributor

github-actions bot commented Jan 8, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 8, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 8, 2025 16:30
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 8, 2025
Merged via the queue into Homebrew:master with commit 62d7b4a Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants