Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jj: resolve redirect to jj-vcs GH org. #203007

Merged
merged 1 commit into from
Jan 3, 2025
Merged

jj: resolve redirect to jj-vcs GH org. #203007

merged 1 commit into from
Jan 3, 2025

Conversation

ErichDonGubler
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jan 2, 2025
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. repo-location-update labels Jan 2, 2025
@chenrui333 chenrui333 added this pull request to the merge queue Jan 2, 2025
@chenrui333
Copy link
Member

@ErichDonGubler thanks for your first contribution to homebrew-core! 💯

@carlocab carlocab removed this pull request from the merge queue due to a manual request Jan 2, 2025
@carlocab carlocab marked this pull request as draft January 2, 2025 17:18
@carlocab
Copy link
Member

carlocab commented Jan 2, 2025

Let's wait for #202651 to merge first.

@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 2, 2025
@chenrui333 chenrui333 changed the title refactor(jj): resolve redirect to jj-vcs GH org. jj: resolve redirect to jj-vcs GH org. Jan 2, 2025
@chenrui333
Copy link
Member

@ErichDonGubler please rebase your PR to the latest master, thanks!

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 2, 2025
@carlocab carlocab marked this pull request as ready for review January 2, 2025 19:46
@ErichDonGubler
Copy link
Contributor Author

@chenrui333: Done!

@carlocab carlocab enabled auto-merge January 3, 2025 01:12
@carlocab carlocab added CI-no-bottles Merge without publishing bottles and removed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Jan 3, 2025
@carlocab carlocab added this pull request to the merge queue Jan 3, 2025
Merged via the queue into Homebrew:master with commit 11a2f96 Jan 3, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles repo-location-update rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErichDonGubler @chenrui333 @carlocab