Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust: use LLVM 19, dynamically link to LLVM #202964

Merged
merged 2 commits into from
Jan 2, 2025
Merged

faust: use LLVM 19, dynamically link to LLVM #202964

merged 2 commits into from
Jan 2, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jan 2, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow up to #202945 to remove static linkage. I think this also drops indirect linkage.

@cho-m cho-m added the in progress Stale bot should stay away label Jan 2, 2025
carlocab
carlocab previously approved these changes Jan 2, 2025
@carlocab carlocab mentioned this pull request Jan 2, 2025
6 tasks
daeho-ro
daeho-ro previously approved these changes Jan 2, 2025
Base automatically changed from faust to master January 2, 2025 15:24
@BrewTestBot BrewTestBot dismissed stale reviews from daeho-ro and carlocab January 2, 2025 15:24

The base branch was changed.

@cho-m cho-m marked this pull request as ready for review January 2, 2025 16:44
@cho-m cho-m removed the in progress Stale bot should stay away label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 2, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 2, 2025 17:18
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 2, 2025
Merged via the queue into master with commit 8388cd1 Jan 2, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the faust-llvm branch January 2, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants