Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk-vnc: add indirect dependencies #202946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

gtk-vnc: add indirect dependencies #202946

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Jan 1, 2025

Fixes:
Full linkage --cached --test --strict gtk-vnc output
Indirect dependencies with linkage:
at-spi2-core
harfbuzz
libx11
pango

I took the opportunity to move the gettext build dep to the on_linux block:

  • it's a build time dep on Linux
  • it's a normal dep on macOS
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka mentioned this pull request Jan 1, 2025
Fixes:
Full linkage --cached --test --strict gtk-vnc output
  Indirect dependencies with linkage:
    at-spi2-core
    harfbuzz
    libx11
    pango

I took the opportunity to move the gettext build dep to the on_linux block:
- it's a build time dep on Linux
- it's a normal dep on macOS

Also fixed the homepage url that links to a broken website
depends_on "gobject-introspection" => :build
depends_on "meson" => :build
depends_on "ninja" => :build
depends_on "pkgconf" => :build

depends_on "at-spi2-core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no linkage for this?

depends_on "libgcrypt"
depends_on "libx11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be linux dep only?

@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Jan 2, 2025
@cho-m
Copy link
Member

cho-m commented Jan 2, 2025

As note, linkage failures on Ventura/Sonoma bottles can be incorrect for meson-based formulae if they haven't been rebuilt recently.

Usually need to verify Monterey/Sequoia bottles, which never used buggy Xcode 15 linker.

Otherwise will end up incorrectly adding dependencies. If want to get rid of warning, then need new bottles.


EDIT: Specifically, this is due to meson's default usage of -dead_strip_dylibs/--as-needed which was broken on some Xcode 15 releases when using new linker. brew has a workaround to use -ld_classic for buggy Xcode versions.

@@ -45,7 +48,7 @@ class GtkVnc < Formula
end

on_linux do
depends_on "libx11"
depends_on "gettext" => :build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a macOS dependency (see on_macos block above), so we can make the :build dependency unconditional

@chenrui333 chenrui333 marked this pull request as draft January 2, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants