-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtk-vnc: add indirect dependencies #202946
base: master
Are you sure you want to change the base?
Conversation
Fixes: Full linkage --cached --test --strict gtk-vnc output Indirect dependencies with linkage: at-spi2-core harfbuzz libx11 pango I took the opportunity to move the gettext build dep to the on_linux block: - it's a build time dep on Linux - it's a normal dep on macOS Also fixed the homepage url that links to a broken website
depends_on "gobject-introspection" => :build | ||
depends_on "meson" => :build | ||
depends_on "ninja" => :build | ||
depends_on "pkgconf" => :build | ||
|
||
depends_on "at-spi2-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no linkage for this?
depends_on "libgcrypt" | ||
depends_on "libx11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be linux dep only?
As note, linkage failures on Ventura/Sonoma bottles can be incorrect for Usually need to verify Monterey/Sequoia bottles, which never used buggy Xcode 15 linker. Otherwise will end up incorrectly adding dependencies. If want to get rid of warning, then need new bottles. EDIT: Specifically, this is due to |
@@ -45,7 +48,7 @@ class GtkVnc < Formula | |||
end | |||
|
|||
on_linux do | |||
depends_on "libx11" | |||
depends_on "gettext" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also a macOS dependency (see on_macos
block above), so we can make the :build
dependency unconditional
Fixes:
Full linkage --cached --test --strict gtk-vnc output
Indirect dependencies with linkage:
at-spi2-core
harfbuzz
libx11
pango
I took the opportunity to move the gettext build dep to the on_linux block:
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?