Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmq 3.1.3 (new formula) #202901

Merged
merged 2 commits into from
Jan 2, 2025
Merged

xmq 3.1.3 (new formula) #202901

merged 2 commits into from
Jan 2, 2025

Conversation

Omoeba
Copy link
Contributor

@Omoeba Omoeba commented Jan 1, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The git repository does not reach the notability requirement, but it is referenced by other formulae in homebrew/core, well-maintained with an active commit history, and well-documented. Therefore, I believe it is a useful addition to homebrew/core.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 1, 2025
@Omoeba Omoeba force-pushed the xmq-new branch 4 times, most recently from 3675c1e to ea81f39 Compare January 1, 2025 07:55
@Omoeba
Copy link
Contributor Author

Omoeba commented Jan 1, 2025

Not sure why it is still failing, maybe there needs to be some additional args to pkgconf?

@Omoeba Omoeba requested a review from chenrui333 January 1, 2025 08:38
@daeho-ro daeho-ro added notability Project is not notable enough for inclusion CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 1, 2025
@daeho-ro
Copy link
Member

daeho-ro commented Jan 1, 2025

Configure script is a bit weird, it is looking for .lib folder?

else
    with_libxml2=$(realpath ${with_libxml2})
    IDIR=$(find ${with_libxml2} -path "*/libxml/tree.h" | sed 's|/libxml/tree.h||')
    LIBXML2_CFLAGS="-I${IDIR}"
    if test -z "$IDIR"; then
        as_fn_error $? "Could not find libxml/tree.h below ${with_libxml2}" "$LINENO" 5
    fi
    LIBNAME="libxml2-2.dll"
    LIBF=$(find ${with_libxml2} -name "${LIBNAME}")
    LIBXML2_LIBS="-Wl,-Bstatic ${LIBF}"

    if test -z "$LIBF"; then
       LIBNAME="libxml2_la-tree.o"
       LIBF=$(find ${with_libxml2}/.libs -name "${LIBNAME}" | head -n 1)
       LIBXML2_LIBS=$(find ${with_libxml2}/.libs -name "*.o" | tr '\n' ' ')
    fi
    if test -z "$LIBF"; then
        as_fn_error $? "Could not find ${LIBNAME} below ${with_libxml2}" "$LINENO" 5
    fi
    { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: using ${with_libxml2}" >&5
printf "%s\n" "using ${with_libxml2}" >&6; }
fi

@Omoeba
Copy link
Contributor Author

Omoeba commented Jan 1, 2025

I was just looking at the configure.ac file and noticed the weirdness too. It is also strange how pkg-config is used for zlib but not libxml2 or libxslt. I'll check with upstream and hopefully merge some sort of fix.

@Omoeba Omoeba changed the title xmq 3.1.1 (new formula) xmq 3.1.2 (new formula) Jan 2, 2025
@Omoeba Omoeba changed the title xmq 3.1.2 (new formula) xmq 3.1.3 (new formula) Jan 2, 2025
@Omoeba
Copy link
Contributor Author

Omoeba commented Jan 2, 2025

The Linux install issue should be fixed but the CI run was cancelled due to the notability audit fail.

@daeho-ro daeho-ro added the CI-skip-new-formulae Pass --skip-new to brew test-bot. label Jan 2, 2025
@Omoeba
Copy link
Contributor Author

Omoeba commented Jan 2, 2025

Is there anything else needed for this to be merged?

Formula/x/xmq.rb Outdated Show resolved Hide resolved
Formula/x/xmq.rb Outdated Show resolved Hide resolved
Formula/x/xmq.rb Outdated Show resolved Hide resolved
@Omoeba
Copy link
Contributor Author

Omoeba commented Jan 2, 2025

@chenrui333 Thanks for the review! Everything should be in order now.

@Omoeba Omoeba requested a review from SMillerDev January 2, 2025 16:54
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Omoeba ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@SMillerDev SMillerDev added this pull request to the merge queue Jan 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 2, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 2, 2025 17:29
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 2, 2025
Merged via the queue into Homebrew:master with commit c6cc251 Jan 2, 2025
15 checks passed
@Omoeba Omoeba deleted the xmq-new branch January 2, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants