-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netatalk 4.0.8 (new formula) #202713
netatalk 4.0.8 (new formula) #202713
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
4c5e0b4
to
8bb667f
Compare
8bb667f
to
1b6c851
Compare
The remaining CI failures are triggered by the As mentioned in the summary, complying with them and using the macOS supplied libraries will break the software. Can these CI failures be ignored? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR; a few comments.
5e94138
to
3565ce2
Compare
3565ce2
to
24662de
Compare
2b31ec1
to
dac9912
Compare
72a454a
to
5e76486
Compare
4ebf570
to
1195a6c
Compare
1999630
to
a9fa0d2
Compare
I've filed a PR to fix the launchd item not being able to stop the For now, I'd suggest adding a Side note: what's it take to get its user authentication working in modern macOS? With the server running on Sonoma on M3 and logging enabled in |
@EricFromCanada Thanks for filing the PR. Let me follow up over there. The next stable netatalk release is about a week out. Authentication should work out of the box on any host, as long as the Mac client is running Mac OS 8.6, 9.x, or any version of OSX / macOS. What OS is the client Mac running? My first guess would be some kind of PAM library failure on Sonoma. Alternatively, you're using a password that the DHX2 UAM doesn't like for some reason. If you like, you can open up a Discussion thread over at the netatalk GitHub project and we can dig into it. |
@EricFromCanada Patch applied to the formula. The brew services control works so much better this way. Great idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
? (see caveat below)Please note that
brew audit --new netatalk
throws non-compliance as per the below. However, the native macOSberkeley-db
andopenldap
libraries are both unusable: The former lacks required symbols, and the latter (represented by LDAP.Framework) isn't fork safe while netatalk is a forking application.