Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatalk 4.0.8 (new formula) #202713

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

rdmark
Copy link
Contributor

@rdmark rdmark commented Dec 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>? (see caveat below)

Please note that brew audit --new netatalk throws non-compliance as per the below. However, the native macOS berkeley-db and openldap libraries are both unusable: The former lacks required symbols, and the latter (represented by LDAP.Framework) isn't fork safe while netatalk is a forking application.

brew audit --new netatalk                                                  
netatalk
  * Dependency 'berkeley-db' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
  * Dependency 'openldap' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue labels Dec 29, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@rdmark rdmark force-pushed the netatalk-4-0-8 branch 3 times, most recently from 4c5e0b4 to 8bb667f Compare December 29, 2024 15:02
@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 29, 2024
@rdmark
Copy link
Contributor Author

rdmark commented Dec 29, 2024

The remaining CI failures are triggered by the brew audit checks, AFAICT.

As mentioned in the summary, complying with them and using the macOS supplied libraries will break the software. Can these CI failures be ignored?

@carlocab carlocab added CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. and removed build failure CI fails while building the software labels Dec 29, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; a few comments.

Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 29, 2024
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 2 times, most recently from 5e94138 to 3565ce2 Compare December 29, 2024 22:18
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 29, 2024
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 30, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 30, 2024
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 3 times, most recently from 72a454a to 5e76486 Compare December 30, 2024 16:47
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 31, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 6, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 6, 2025
@rdmark rdmark requested a review from EricFromCanada January 6, 2025 22:13
Formula/n/netatalk.rb Show resolved Hide resolved
Formula/n/netatalk.rb Show resolved Hide resolved
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 2 times, most recently from 1999630 to a9fa0d2 Compare January 7, 2025 22:23
@EricFromCanada
Copy link
Member

I've filed a PR to fix the launchd item not being able to stop the netatalk process: Netatalk/netatalk#1859

For now, I'd suggest adding a patch stanza to integrate the above fix, unless the next netatalk release is imminent.

Side note: what's it take to get its user authentication working in modern macOS? With the server running on Sonoma on M3 and logging enabled in afp.conf, clicking "Connect As…" on another Mac and entering my credentials just logs (info:ad): DHX2: PAM_Error: authentication error.

@rdmark
Copy link
Contributor Author

rdmark commented Jan 8, 2025

@EricFromCanada Thanks for filing the PR. Let me follow up over there. The next stable netatalk release is about a week out.

Authentication should work out of the box on any host, as long as the Mac client is running Mac OS 8.6, 9.x, or any version of OSX / macOS. What OS is the client Mac running?

My first guess would be some kind of PAM library failure on Sonoma. Alternatively, you're using a password that the DHX2 UAM doesn't like for some reason. If you like, you can open up a Discussion thread over at the netatalk GitHub project and we can dig into it.

@rdmark
Copy link
Contributor Author

rdmark commented Jan 8, 2025

@EricFromCanada Patch applied to the formula. The brew services control works so much better this way. Great idea!

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 9, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 9, 2025 17:03
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 9, 2025
Merged via the queue into Homebrew:master with commit eadbee5 Jan 9, 2025
15 checks passed
@rdmark rdmark deleted the netatalk-4-0-8 branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants