Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsarctl 3.3.0.3 (new formula) #175375

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Needed a livecheck due to an old calver tag and github_latest isn't accurate either (latest is v3.0.5.4 but their tap is on v3.3.0.1)

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 22, 2024
@chenrui333
Copy link
Member

why not use latest v3.0.5.4 ?

@branchvincent
Copy link
Member Author

Cause

latest is v3.0.5.4 but their tap is on v3.3.0.1

So it seems like they are maintaining multiple minor versions in parallel

@chenrui333
Copy link
Member

I feel like it is more of goreleaser flow issue :), can you raise an upstream issue to confirm about this? I'd prefer 3.0.5.4

Formula/p/pulsarctl.rb Outdated Show resolved Hide resolved
@branchvincent
Copy link
Member Author

Are they using goreleaser? I don't see a .goreleaser.yaml

But streamnative/pulsarctl#980 (comment) confirms they are maintaining muliple minor versions in parallel, as they track the same minor versions as pulsar (and the latest there is 3.3.x)

@chenrui333
Copy link
Member

yeah, they dont use it, it would be better that they use it to automate the tap updates.

Copy link
Contributor

Copy link
Contributor

⚠️ @branchvincent bottle publish failed.

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 22, 2024
@BrewTestBot BrewTestBot enabled auto-merge June 22, 2024 23:25
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 22, 2024
Merged via the queue into Homebrew:master with commit c9c4ced Jun 22, 2024
14 checks passed
@branchvincent branchvincent deleted the pulsarctl branch June 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants