Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cask - Flowkeeper #197160

Closed
wants to merge 2 commits into from
Closed

Conversation

nuxlight
Copy link

@nuxlight nuxlight commented Jan 4, 2025

Proposing this new Cask for the App Flowkeeper.

I just can't pass the audit validation due to latest version (that is in release candidate)

Error output :

bash-5.2$ brew audit --cask --new flowkeeper
==> Downloading and extracting artifacts
==> Downloading https://github.com/flowkeeper-org/fk-desktop/releases/download/v0.8.1/Flowkeeper.dmg
Already downloaded: /Users/user/Library/Caches/Homebrew/downloads/11eaa2eb7116f284e7aa6f8f020b93a4b08d0f6636c03fbc8c87cd2b0716e4c0--Flowkeeper.dmg
==> Downloading https://github.com/flowkeeper-org/fk-desktop/releases/download/v0.8.1/Flowkeeper.dmg
Already downloaded: /Users/user/Library/Caches/Homebrew/downloads/11eaa2eb7116f284e7aa6f8f020b93a4b08d0f6636c03fbc8c87cd2b0716e4c0--Flowkeeper.dmg
audit for flowkeeper: failed
 - GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
 - Version 'v0.8.1' differs from '0.9.0' retrieved by livecheck.
 - Version 'v0.8.1' differs from '0.9.0' retrieved by livecheck.
 - The URL's domain github.com does not match the homepage domain flowkeeper.org, a 'verified' parameter has to be added to the 'url' stanza. See https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified
flowkeeper
  * line 9, col 4: GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
  * Version 'v0.8.1' differs from '0.9.0' retrieved by livecheck.
  * The URL's domain github.com does not match the homepage domain flowkeeper.org, a 'verified' parameter has to be added to the 'url' stanza. See https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified
Error: 3 problems in 1 cask detected.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Thibaud Pellissier added 2 commits January 4, 2025 11:31
Signed-off-by: Thibaud Pellissier <[email protected]>
@nuxlight nuxlight changed the title New Cask -Flowkeeper New Cask - Flowkeeper Jan 4, 2025
@khipp
Copy link
Member

khipp commented Jan 4, 2025

Thank you for your submission @nuxlight, but we cannot accept it at this time because it does not meet our minimum notability requirements:

  • App is too obscure. Examples:
    • An app from a code repository that is not notable enough (under 30 forks, 30 watchers, 75 stars).

Please consider hosting this in your own Tap and if it gets notable enough we would then be happy to consider adding this to homebrew-cask.

@khipp khipp closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants