Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nessus: link binaries #196956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nessus: link binaries #196956

wants to merge 1 commit into from

Conversation

i0ntempest
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@i0ntempest i0ntempest marked this pull request as draft January 2, 2025 09:40
@i0ntempest
Copy link
Contributor Author

See https://github.com/orgs/Homebrew/discussions/5845. Ideally some of these binaries should be linked to the sbin folder instead of bin, but I found no ways to do this.

@i0ntempest i0ntempest changed the title nessus: link binaries [Help needed] nessus: link binaries Jan 2, 2025
@SMillerDev
Copy link
Member

If the upstream pkg doesn't install it, should we?

@i0ntempest
Copy link
Contributor Author

If the upstream pkg doesn't install it, should we?

Upstream has documentation that reference these binaries, linking them just makes them more accessible. For example see https://docs.tenable.com/nessus/command-line-reference/Content/ResetRegistrationAndEraseSettings.htm

@i0ntempest
Copy link
Contributor Author

@SMillerDev Is it at all possible to link cask binaries to /opt/homebrew/sbin? Either way I want to mark this one as ready.

@bevanjkay
Copy link
Member

@SMillerDev Is it at all possible to link cask binaries to /opt/homebrew/sbin? Either way I want to mark this one as ready.

What happens if you use target on the binary?

@i0ntempest
Copy link
Contributor Author

@SMillerDev Is it at all possible to link cask binaries to /opt/homebrew/sbin? Either way I want to mark this one as ready.

What happens if you use target on the binary?

@bevanjkay Specifying a path using#{prefix}/sbin/nessuscli didn't work, it complained Unexpected method 'prefix' called on Cask. Seems #{prefix} isn't available for casks. Hardcoding the path worked but that obviously isn't ideal.

@i0ntempest
Copy link
Contributor Author

@SMillerDev Is it at all possible to link cask binaries to /opt/homebrew/sbin? Either way I want to mark this one as ready.

What happens if you use target on the binary?

target: "../sbin/nessuscli" worked fine. Is there a better way?

@i0ntempest i0ntempest changed the title [Help needed] nessus: link binaries nessus: link binaries Jan 4, 2025
@i0ntempest i0ntempest marked this pull request as ready for review January 4, 2025 02:19
@i0ntempest
Copy link
Contributor Author

Marked as ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants