Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import brew formula-analytics and generate-analytics-api commands #19259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MikeMcQuaid
Copy link
Member

Import these from the homebrew/formula-analytics tap and deprecate that tap.

This required a little messing around with filenames and paths to get it finding Python and writing to the user's home directory.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (though difficult to review any changes to the actual code) but it needs full run tests and an update to dependabot.yml to point to the nested requirements.txt location.

Library/Homebrew/sorbet/tapioca/config.yml Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid force-pushed the brew_formula_analytics_import branch 2 times, most recently from f3feaee to 78d5c98 Compare February 7, 2025 19:50
@MikeMcQuaid
Copy link
Member Author

@Bo98 Thanks! Should be pretty much sorted based on your comments but feel free to get the final bits over the line here and merge.

@MikeMcQuaid MikeMcQuaid force-pushed the brew_formula_analytics_import branch 2 times, most recently from c2c9251 to 1951261 Compare February 7, 2025 20:01
Import these from the homebrew/formula-analytics tap and deprecate
that tap.

This required a little messing around with filenames and paths to get
it finding Python and writing to the user's home directory.
@MikeMcQuaid MikeMcQuaid force-pushed the brew_formula_analytics_import branch from 1951261 to 6f99704 Compare February 7, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants