Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix comment for ubuntu 18 deprecation #19190

Merged
merged 1 commit into from
Feb 3, 2025
Merged

docker: fix comment for ubuntu 18 deprecation #19190

merged 1 commit into from
Feb 3, 2025

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 1, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Bo98
Copy link
Member

Bo98 commented Feb 1, 2025

It was deprecated with 4.4.0. Plan was to remove it with 4.5.0, unless it's already causing problems.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 but only when next release will be 4.4 (which could be the next release!)

@iMichka
Copy link
Member Author

iMichka commented Feb 1, 2025

I misread the comment in the code then, it said >=4.4.0, but it probably was meant to be >4.4.0?

@MikeMcQuaid you mean 4.5 will be the next release?

@Bo98
Copy link
Member

Bo98 commented Feb 1, 2025

Yeah, the comment has a typo - it's meant to say >=4.5. The first version with it was 4.4.0.

@MikeMcQuaid
Copy link
Member

Yes, @Bo98 is right, sorry for confusion @iMichka!

@iMichka iMichka changed the title docker: stop shipping ubuntu 18 docker: fix comment for ubuntu 18 deprecation Feb 3, 2025
@iMichka iMichka requested a review from MikeMcQuaid February 3, 2025 14:11
@iMichka
Copy link
Member Author

iMichka commented Feb 3, 2025

@Bo98 @MikeMcQuaid let's just fix the comment then

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 7b7bf51 Feb 3, 2025
33 checks passed
@MikeMcQuaid MikeMcQuaid deleted the ubuntu18 branch February 3, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants