-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: fix comment for ubuntu 18 deprecation #19190
Conversation
It was deprecated with 4.4.0. Plan was to remove it with 4.5.0, unless it's already causing problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 but only when next release will be 4.4 (which could be the next release!)
I misread the comment in the code then, it said >=4.4.0, but it probably was meant to be >4.4.0? @MikeMcQuaid you mean 4.5 will be the next release? |
Yeah, the comment has a typo - it's meant to say |
@Bo98 @MikeMcQuaid let's just fix the comment then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?