Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workload & Mongodb Schema #51

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Workload & Mongodb Schema #51

wants to merge 29 commits into from
+878 −68

Conversation

zeeshan595
Copy link

No description provided.

@JettTech JettTech mentioned this pull request Jan 16, 2025
Merged
Base automatically changed from nats-crates to main January 17, 2025 17:39
JettTech
JettTech requested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@JettTech JettTech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the delete fn is still unimplemented, so some of the feedback may be a bit premature. That said, I went ahead and finished the review since we discussed it via DM. Also, I do think that this is a great start! 💪

I really appreciate the clean up of the mongodb id type and the addition of the updated_at and deleted_at fields. I also responded to some of the questions re: the User collection and left some feedback on the update method; let me know if you have any Qs you'd like to sync on.

rust/util_libs/src/db/mongodb.rs Outdated Show resolved Hide resolved
rust/util_libs/src/db/schemas.rs Show resolved Hide resolved
rust/util_libs/src/db/schemas.rs Outdated Show resolved Hide resolved
rust/util_libs/src/db/schemas.rs Outdated Show resolved Hide resolved
rust/util_libs/src/db/schemas.rs Outdated Show resolved Hide resolved
rust/services/workload/src/lib.rs Outdated Show resolved Hide resolved
rust/services/workload/src/lib.rs Outdated Show resolved Hide resolved
rust/services/workload/src/lib.rs Outdated Show resolved Hide resolved
rust/services/workload/src/lib.rs Outdated Show resolved Hide resolved
rust/services/workload/src/lib.rs Show resolved Hide resolved
zeeshan595 and others added 12 commits January 20, 2025 17:08
@zeeshan595 @JettTech
Update rust/util_libs/src/db/schemas.rs
6333f1c 
Co-authored-by: Lisa Jetton <[email protected]>
@zeeshan595 @JettTech
Update rust/util_libs/src/db/mongodb.rs
85a42ad 
Co-authored-by: Lisa Jetton <[email protected]>
@zeeshan595 @JettTech
Update rust/services/workload/src/lib.rs
e9ccd31 
Co-authored-by: Lisa Jetton <[email protected]>
@zeeshan595 @JettTech
Update rust/services/workload/src/lib.rs
025b5c0 
Co-authored-by: Lisa Jetton <[email protected]>
@zeeshan595
Merge branch 'main' into delete_workload
934889e
@zeeshan595 @JettTech
Update rust/orchestrator/src/hello.rs
075e331 
Co-authored-by: Lisa Jetton <[email protected]>
@zeeshan595 @JettTech
Update rust/services/workload/src/lib.rs
034ba7f 
Co-authored-by: Lisa Jetton <[email protected]>
improved mapping
a4850c2
Merge branch 'delete_workload' of github.com:Holo-Host/holo-host into…
6623bf4 
… delete_workload
@zeeshan595 @JettTech
Update rust/services/workload/src/lib.rs
e795177 
Co-authored-by: Lisa Jetton <[email protected]>
removed clone from _id
024b2ee
added workload state called updating
d50c9fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JettTech JettTech JettTech requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeeshan595 @JettTech