-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some remaining exercises in Chapter 2 #2190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just a couple of comments.
contrib/HoTTBookExercises.v
Outdated
@@ -700,7 +703,16 @@ Definition Book_2_13 := @HoTT.Types.Bool.equiv_bool_aut_bool. | |||
(* ================================================== ex:dep-htpy-natural *) | |||
(** Exercise 2.18 *) | |||
|
|||
(** This exercise is solved in the library as HoTT.Basics.PathGroupoids.apD_homotopic *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(** This exercise is solved in the library as HoTT.Basics.PathGroupoids.apD_homotopic *) | |
(** This exercise is solved in the library as HoTT.Basics.PathGroupoids.apD_homotopic, except that the equation is rearranged slightly. *) |
Or maybe this version should be added to the library, to be analogous to concat_Ap
? And then apD_homotopic
could be proved using this new result? @Alizter , what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds sensible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great! I'm happy with this once you've addressed Dan's suggestion of adding a variant of apD_homotopic
. Not sure what to name that though. It ought to be something like concat_Ap
but that doesn't quite work since we are doing some sort of dependent concatenation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great! I'm happy with this once you've addressed Dan's suggestion of adding a variant of apD_homotopic
. Not sure what to name that though. It ought to be something like concat_Ap
but that doesn't quite work since we are doing some sort of dependent concatenation.
Co-authored-by: Dan Christensen <[email protected]>
What if we just call it |
Looks great, thanks! @jdchristensen feel free to merge when you've taken a look. |
Thanks, @Theongck! If you'd like to contribute more to the library, that would be great! I'll merge once most of the CI passes. |
No description provided.