Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some remaining exercises in Chapter 2 #2190

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

Theongck
Copy link
Contributor

@Theongck Theongck commented Jan 8, 2025

No description provided.

Copy link
Collaborator

@jdchristensen jdchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a couple of comments.

contrib/HoTTBookExercises.v Outdated Show resolved Hide resolved
@@ -700,7 +703,16 @@ Definition Book_2_13 := @HoTT.Types.Bool.equiv_bool_aut_bool.
(* ================================================== ex:dep-htpy-natural *)
(** Exercise 2.18 *)

(** This exercise is solved in the library as HoTT.Basics.PathGroupoids.apD_homotopic *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(** This exercise is solved in the library as HoTT.Basics.PathGroupoids.apD_homotopic *)
(** This exercise is solved in the library as HoTT.Basics.PathGroupoids.apD_homotopic, except that the equation is rearranged slightly. *)

Or maybe this version should be added to the library, to be analogous to concat_Ap? And then apD_homotopic could be proved using this new result? @Alizter , what do you think?

Copy link
Collaborator

@Alizter Alizter Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds sensible.

Copy link
Collaborator

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! I'm happy with this once you've addressed Dan's suggestion of adding a variant of apD_homotopic. Not sure what to name that though. It ought to be something like concat_Ap but that doesn't quite work since we are doing some sort of dependent concatenation.

Copy link
Collaborator

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! I'm happy with this once you've addressed Dan's suggestion of adding a variant of apD_homotopic. Not sure what to name that though. It ought to be something like concat_Ap but that doesn't quite work since we are doing some sort of dependent concatenation.

Co-authored-by: Dan Christensen <[email protected]>
@jdchristensen
Copy link
Collaborator

Thanks, this is great! I'm happy with this once you've addressed Dan's suggestion of adding a variant of apD_homotopic. Not sure what to name that though. It ought to be something like concat_Ap but that doesn't quite work since we are doing some sort of dependent concatenation.

What if we just call it apD_natural and put it right before apD_homotopic? (I'm also tempted to rename concat_Ap to ap_natural, but then there would be many other similar results of the form "concat_...A..." that would not fit into the pattern.)

@Alizter
Copy link
Collaborator

Alizter commented Jan 10, 2025

Looks great, thanks! @jdchristensen feel free to merge when you've taken a look.

@jdchristensen
Copy link
Collaborator

Thanks, @Theongck! If you'd like to contribute more to the library, that would be great!

I'll merge once most of the CI passes.

@jdchristensen jdchristensen merged commit 2267ab0 into HoTT:master Jan 10, 2025
20 checks passed
@Theongck Theongck deleted the exercise-2 branch January 10, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants