Don't Export all of Classes.interfaces.abstract_algebra #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids putting all of the names and notations from Classes into the HoTT namespace.
jdchristensen
commented
Oct 17, 2023
|
@Alizter Do you think this is good now? |
Alizter
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes.interfaces.abstract_algebra exports Classes.interfaces.canonical names, which has a lot of things it. I didn't want to change that export, since I'd have to fix a lot in the Classes library.
Instead, I adjusted the few files that exported abstract_algebra to either not do so, or do so very selectively. This avoids putting all of the names and notations from Classes into the HoTT namespace. For example, the Classes
Joinwas conflicting with theJoinwe have, and the ClassesJoinwas the winner. Lots of files touched, but mainly because they needBasicsandTypesadded in (and sometimesTruncations.Core), since canonical_names exports those.