Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): update EditUser & InviteUser dialogs #713

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation is to refactor the EditUser and InviteUser code bases to use useDialogs hook instead of using useDialog hook.

Fixes #712

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the refactor Restructuring existing source code label Feb 7, 2025
@yassinedorbozgithub yassinedorbozgithub self-assigned this Feb 7, 2025
@yassinedorbozgithub yassinedorbozgithub linked an issue Feb 7, 2025 that may be closed by this pull request
@abdou6666
Copy link
Member

abdou6666 commented Feb 7, 2025

I noticed this error:

image

reproduction steps :

  1. go to : http://localhost:8080/users
  2. refresh the page
  3. click on invite

This error's probably happening in all dialogs we should check them

@yassinedorbozgithub
Copy link
Collaborator Author

Hi @abdou6666, thank you for the review 🙌
i will investigate about the root cause

@abdou6666
Copy link
Member

The onSubmit issue has been resolved!

@yassinedorbozgithub
Copy link
Collaborator Author

yassinedorbozgithub commented Feb 7, 2025

Hi @abdou6666, it's a good news that this issue is resolved 🚀
Thank you for reporting this bug 🙌

@marrouchi marrouchi merged commit 503973e into main Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructuring existing source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Users dialogs (invite, manage)
3 participants