Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): update menu dialogs #705

Merged

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation is to refactor the Menu code base to use useDialogs hook instead of using useDialog hook.

Fixes #700

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the refactor Restructuring existing source code label Feb 6, 2025
@yassinedorbozgithub yassinedorbozgithub self-assigned this Feb 6, 2025
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yassinedorbozgithub
I noticed this error and it's already existing in the main branch
image

@yassinedorbozgithub yassinedorbozgithub changed the base branch from 692-create-genericformdialog-component to main February 6, 2025 15:16
@yassinedorbozgithub
Copy link
Collaborator Author

Hi @IkbelTalebHssan, first of all thank you for reporting this bug 🙏
The bug is coming from the validator exaclty from isAbsoluteUrl function.

@yassinedorbozgithub yassinedorbozgithub linked an issue Feb 6, 2025 that may be closed by this pull request
@yassinedorbozgithub
Copy link
Collaborator Author

Hi @IkbelTalebHssan, bug fixed 🚀

@abdou6666
Copy link
Member

abdou6666 commented Feb 7, 2025

@yassinedorbozgithub when we toggle the checkbox the previous value in the input disappears even though the value is still binded to the input :
Screencast from 07-02-25 13:54:59.webm

@yassinedorbozgithub
Copy link
Collaborator Author

Hi @abdou6666, i will double check the reported issue, thank you 🙌

@yassinedorbozgithub
Copy link
Collaborator Author

Hi @abdou6666, this behavior is happening because the postback checkbox status (true is the title !== postback) is not saved in the DB.

Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yassinedorbozgithub
I noticed this misbehavior when editing a postback menu :
A new field added named url
image
Please note that this problem occurs also in the main branch that means that this issue is not related to the changes made in this PR 🙏

@yassinedorbozgithub
Copy link
Collaborator Author

Hi @IkbelTalebHssan, thank you for the review,
100% right, nice catch 🙏 i have reproduce this issue by following the mentioned description
I will fix this bug and keep you informed 🧑‍💻

@marrouchi marrouchi merged commit 1781884 into main Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructuring existing source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Manage Persistent Menu dialogs (add, edit, delete)
4 participants