-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend): update menu dialogs #705
refactor(frontend): update menu dialogs #705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yassinedorbozgithub
I noticed this error and it's already existing in the main branch
Hi @IkbelTalebHssan, first of all thank you for reporting this bug 🙏 |
Hi @IkbelTalebHssan, bug fixed 🚀 |
@yassinedorbozgithub when we toggle the checkbox the previous value in the input disappears even though the value is still binded to the input : |
Hi @abdou6666, i will double check the reported issue, thank you 🙌 |
Hi @abdou6666, this behavior is happening because the postback checkbox status (true is the title !== postback) is not saved in the DB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yassinedorbozgithub
I noticed this misbehavior when editing a postback menu :
A new field added named url
Please note that this problem occurs also in the main branch that means that this issue is not related to the changes made in this PR 🙏
Hi @IkbelTalebHssan, thank you for the review, |
Motivation
The main motivation is to refactor the Menu code base to use useDialogs hook instead of using useDialog hook.
Fixes #700
Checklist: