fix(api): optimize performance in preUpdateMany #549
+29
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdou6666
approved these changes
Jan 10, 2025
MohamedAliBouhaouala
approved these changes
Jan 10, 2025
yassinedorbozgithub
requested changes
Jan 12, 2025
| if (oldState && oldState.category !== category) { | ||
| const updatedNextBlocks = oldState.nextBlocks?.filter((nextBlock) => | ||
|
|
||
| const oldStates: Block[] = await this.find({ _id: { $in: ids } }); |
There was a problem hiding this comment.
Suggested change
| const oldStates: Block[] = await this.find({ _id: { $in: ids } }); | |
| const oldStates = await this.find({ _id: { $in: ids } }); |
The find method will return the expected type Block[]
marrouchi
requested changes
Jan 28, 2025
| if (oldState && oldState.category !== category) { | ||
| const updatedNextBlocks = oldState.nextBlocks?.filter((nextBlock) => | ||
|
|
||
| const oldStates: Block[] = await this.find({ _id: { $in: ids } }); |
There was a problem hiding this comment.
@omarNaifer12 thanks for your contribution.
In addition to @yassinedorbozgithub comment, I suggest adding the criteria "different category" so that we avoid the "if" condition inside the loop.
There was a problem hiding this comment.
Thank you @marrouchi for the feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updated the function prepareBlocksInCategoryUpdateScope to replace multiple findOne API calls with a single API call. Updated its tests accordingly
Fixes #536
Type of change:
Please delete options that are not relevant.
Checklist: