Validator form #760
Merged
Validator form #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sispheor
reviewed
Jan 5, 2024
| # Survey validators | ||
|
|
||
| Survey validators are Python modules that can be added as plugin. It allows users to implement their own validation | ||
| logic on a day1 or day2 operation. |
There was a problem hiding this comment.
against all field of the survey instead of only one single field with with the "field_validator"
There was a problem hiding this comment.
Do we want to keep field validator ? Maybe we can stop to maintain field validators and tell users to move on survey validators. They are more user friendly and you can use the same code for both UI and API.
If we decide to stop field validators in X months, we should not include a citation here. Need to discuss
Sispheor
reviewed
Jan 5, 2024
Comment on lines
91
to
92
| if squest_stars_on_github <= 250: | ||
| self.fail("Number of stars on Squest is below 250, come back when it's 251") |
There was a problem hiding this comment.
not a really good example :)
Sispheor
reviewed
Jan 5, 2024
|
|
||
| ## Fix | ||
|
|
||
| - Hide disabled operations from Instance view |
There was a problem hiding this comment.
and the line that correspond to this feature?
Sispheor
reviewed
Jan 5, 2024
service_catalog/forms/form_utils.py
Outdated
|
|
||
| from rest_framework.exceptions import ValidationError | ||
|
|
||
| logger = logging.getLogger(__name__) |
Sispheor
reviewed
Jan 5, 2024
a-belhadj
force-pushed
the
validator_form
branch
3 times, most recently
from
e803787 to
7aad5bb
Compare
EliasBoulharts
approved these changes
Jan 8, 2024
a-belhadj
force-pushed
the
validator_form
branch
2 times, most recently
from
79a2a3b to
1f8b63e
Compare
Sispheor
reviewed
Jan 8, 2024
| @@ -341,6 +341,12 @@ Change the format of all date in Squest UI. Based on Python [strftime](https://s | |||
|
|
|||
| Path to form field validation modules. | |||
|
|
|||
| ### SURVEY_VALIDATOR_PATH | |||
There was a problem hiding this comment.
add deprecation warning on the other field
Sispheor
force-pushed
the
validator_form
branch
from
31fb639 to
13a14d3
Compare
a-belhadj
force-pushed
the
validator_form
branch
from
13a14d3 to
0eba1ea
Compare
Sispheor
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.