address review comments

HewlettPackard · Feb 3, 2022 · 72dfe32 · 72dfe32
1 parent c454a59
commit 72dfe32
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/internal/acceptance_test/helper.go b/internal/acceptance_test/helper.go
@@ -33,7 +33,7 @@ func getAPIClient() (*api_client.APIClient, api_client.Configuration) {
 	}
 
 	apiClient := api_client.NewAPIClient(&cfg)
-	meta_err := apiClient.SetMeta(nil, func(ctx *context.Context, meta interface{}) {
+	err := apiClient.SetMeta(nil, func(ctx *context.Context, meta interface{}) {
 		d := &utils.ResourceData{
 			Data: map[string]interface{}{
 				"iam_service_url":           os.Getenv("HPEGL_IAM_SERVICE_URL"),
@@ -64,8 +64,8 @@ func getAPIClient() (*api_client.APIClient, api_client.Configuration) {
 		}
 	})
 
-	if meta_err != nil {
-		log.Printf("[WARN] Error: %s", meta_err)
+	if err != nil {
+		log.Printf("[WARN] Error: %s", err)
 	}
 
 	return apiClient, cfg

diff --git a/pkg/atf/helper.go b/pkg/atf/helper.go
@@ -4,6 +4,7 @@ import (
 	"crypto/md5"
 	"encoding/json"
 	"fmt"
+	"log"
 	"math/rand"
 	"runtime"
 	"strconv"
@@ -89,7 +90,7 @@ func newRand() *rand.Rand {
 	m := md5.New()
 	_, err := m.Write([]byte(s))
 	if err != nil {
-		panic(err)
+		log.Printf("[WARN]: Error while writing to Hash object %s", err)
 	}
 	sourceStr := m.Sum(nil)
 	var sourceInt int64

diff --git a/pkg/utils/meta.go b/pkg/utils/meta.go
@@ -11,7 +11,7 @@ import (
 )
 
 func SetMeta(apiClient *client.APIClient, r *schema.ResourceData) {
-	meta_err := apiClient.SetMeta(nil, func(ctx *context.Context, meta interface{}) {
+	err := apiClient.SetMeta(nil, func(ctx *context.Context, meta interface{}) {
 		// Initialise token handler
 		h, err := serviceclient.NewHandler(r)
 		if err != nil {
@@ -28,7 +28,7 @@ func SetMeta(apiClient *client.APIClient, r *schema.ResourceData) {
 		}
 	})
 
-	if meta_err != nil {
-		log.Printf("[WARN] Error: %s", meta_err)
+	if err != nil {
+		log.Printf("[WARN] Error: %s", err)
 	}
 }