Allow supplying client id/secret for auth #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuart-mclaren-hpe
force-pushed
the
creds-env-vars
branch
from
cd4693f to
2ca7cd8
Compare
ZoeySimone
reviewed
Jan 27, 2025
Allow a user to specify a PCBe Client ID and PCBe Client Secret as an alternative to a token. Either (1) a token or (2) credentials (id/secret) must be provided. The code will use the creds to generate a token when a token is not provided directly. Currently the environment variables being used are `PCBE_CLIENT_ID` and `PCBE_CLIENT_SECRET`. These are defined as constants and may be changed later (eg when integrating with the "umbrella" hpegl provider) if desired.
stuart-mclaren-hpe
force-pushed
the
creds-env-vars
branch
from
2ca7cd8 to
3fa247c
Compare
ZoeySimone
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a user to specify a PCBe Client ID and PCBe Client
Secret as an alternative to a token.
Either (1) a token or (2) credentials (id/secret) must be provided.
The code will use the creds to generate a token when a token is
not provided directly.
Currently the environment variables being used are
PCBE_CLIENT_IDandPCBE_CLIENT_SECRET. These are definedas constants and may be changed later (eg when integrating with
the "umbrella" hpegl provider) if desired.