Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow node renaming in ROS2 to avoid duplicate nodes (#22) #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

foiegreis
Copy link

@foiegreis foiegreis commented Feb 17, 2025

Fix: Allow node renaming in ROS2

This PR addresses the issue where launching multiple Hesai LiDAR sensors results in multiple nodes with the same name.
Referring to the issue https://github.com/HesaiTechnology/HesaiLidar_ROS_2.0/issues/22

🔹 Changes:

  • Added a new parameter ros_node_name in the config file to allow setting custom node names.
  • Modified source_drive_common.hpp and source_driver_ros2.hpp
  • Modified driver_param.h in the submodule driver to include:
    std::string ros_node_name;
  • Modified the .gitmodules file to point to my fork

This is my first PR involving submodules, and I may have missed something. I apologize for any mistakes made during the process.
Please refer to the pull request for the HesaiLidarSDK: https://github.com/HesaiTechnology/HesaiLidar_SDK_2.0/pull/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant