Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getpartymember updates #3315

Merged
merged 10 commits into from
Aug 31, 2024
Merged

getpartymember updates #3315

merged 10 commits into from
Aug 31, 2024

Conversation

MishimaHaruna
Copy link
Member

Pull Request Prelude

The getpartymember MRs #3305, #3307, #3308 should be merged into master at the same time, so they were collected into a temporary branch and will be merged through this PR once they're all in.

Changes Proposed

See #3305, #3307, #3308

jasonch35 and others added 8 commits July 27, 2024 21:02
@jasonch35
getpartymember update
9c48f4f 
getpartymember(<party_id>, <type>, <array>);
Will now accept any array as argument
Value returned is the member count
Uses constants:
PT_MEMBER_NAME
PT_MEMBER_CHARID
PT_MEMBER_ACCID

sample usage:
.@count = getpartymember(getcharid(CHAR_ID_PARTY, PT_MEMBER_NAME, .@name$);
@jasonch35
invalid type check
a79cc0d
@jasonch35 @MishimaHaruna
explicit party_data null check
ff322df 
Co-authored-by: Haru <[email protected]>
@jasonch35 @MishimaHaruna
account_id explicit non-zero condition check
84569df 
Co-authored-by: Haru <[email protected]>
@jasonch35
update npc's getpartymember commands
aa5ec29
@jasonch35
update getpartymember doc
a31f32c
@MishimaHaruna
Merge pull request #3305 from jasonch35/getpartymember-upgrade
5a38450 
`getpartymember` upgrade
@MishimaHaruna
Merge pull request #3308 from jasonch35/update-getpartymember-doc
c00541d 
Update getpartymember doc
@MishimaHaruna MishimaHaruna added this to the Release v2024.08 milestone Aug 31, 2024
@MishimaHaruna MishimaHaruna marked this pull request as ready for review August 31, 2024 14:15
@MishimaHaruna MishimaHaruna merged commit 0639fb7 into master Aug 31, 2024
562 of 690 checks passed
@MishimaHaruna MishimaHaruna deleted the getpartymember branch August 31, 2024 16:47
@jasonch35 jasonch35 mentioned this pull request Sep 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2024.08
Development

Successfully merging this pull request may close these issues.
2 participants
@MishimaHaruna @jasonch35