Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getguildmember refactor #3310

Merged

Conversation

jasonch35
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Similar updates to getpartymember #3305 where global variables get overwritten by calling the command by 2 or more players simultaneously.
This update makes the command require an array as its argument and will return the size of the guild.

Constants are GD_MEMBER_NAME, GD_MEMBER_CHARID, and GD_MEMBER_ACCID.

Usage:

.@count = getguildmember(getcharid(CHAR_ID_GUILD), GD_MEMBER_NAME, .@name$);
for (.@i = 0; .@i < .@count; .@i++) {
	consolemes(CONSOLEMES_DEBUG, ""+.@name$[.@i]+"");
}

Issues addressed:
Wrong data when multiple players call the command.

@jasonch35 jasonch35 marked this pull request as ready for review August 6, 2024 20:29
jasonch35 added a commit to jasonch35/Hercules that referenced this pull request Aug 7, 2024
@MishimaHaruna MishimaHaruna changed the base branch from master to getguildmember August 31, 2024 18:09
@MishimaHaruna MishimaHaruna merged commit bd39f4c into HerculesWS:getguildmember Aug 31, 2024
317 of 346 checks passed
MishimaHaruna added a commit that referenced this pull request Aug 31, 2024
@MishimaHaruna MishimaHaruna added this to the Release v2024.08 milestone Aug 31, 2024
@MishimaHaruna MishimaHaruna mentioned this pull request Aug 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants