Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update *getmapinfo script command. #2474

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

Emistry
Copy link
Member

@Emistry Emistry commented May 14, 2019

Pull Request Prelude

Changes Proposed

  • Added parameter MAPINFO_NPC_COUNT to return the total number of NPC exists in the map.
  • Added new server define MAX_NPC_PER_MAP

Issues addressed:
Allow NPC script to validate max npc count in the map before adding new NPC through script command. Useful for #2473

- Added parameter `MAPINFO_NPC_COUNT` to return the total number of NPC
exists in the map.
- Added new server define `MAX_NPC_PER_MAP`
@Emistry Emistry added component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder labels May 14, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@MishimaHaruna MishimaHaruna added this to the Release v2019.06.02 milestone Jun 1, 2019
@MishimaHaruna MishimaHaruna merged commit 0450935 into HerculesWS:master Jun 1, 2019
@Emistry Emistry deleted the scriptcommand_getmapinfo branch June 1, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants