Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds BUILDIN(equipidx); BUILDIN(equip) now returns 0 or 1. #2355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions doc/script_commands.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5603,6 +5603,9 @@ item in his/her inventory, while the autoequip function will equip the
given item ID when this is looted. The option parameter of the autoequip
is 1 or 0, 1 to turn it on, and 0 to turn it off.

equip() returns 1 if the item was successfully equipped and 0 if the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
equip() returns 1 if the item was successfully equipped and 0 if the
Return equipment's position if successful, otherwise it will return false.

item failed to equip.

Examples:

//This will equip a 1104 (falchion) on the character if this is in the
Expand All @@ -5622,6 +5625,30 @@ Examples:

---------------------------------------

*equipidx(<index>)

The equipidx function will attempt to equip the item at the given inventory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The equipidx function will attempt to equip the item at the given inventory
This function will attempt to equip the item at the given

inventory index. This feature is only really useful when multiple instances
of an Item ID exist in the player's inventory.

Returns 1 if the item was successfully equipped.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Returns 1 if the item was successfully equipped.
Return true if successful, otherwise it will return false.

Returns 0 if the item failed to equip.

See getinventorylist() for an explanation on retrieving an inventory index.

Examples:

// This will prioritize equip a rental Knife
getinventorylist();
for (.@i = 0; .@i < @inventorylist_count; ++.@i) {
if (@inventorylist_id[.@i] == Knife && @inventorylist_expire[.@i]) {
equipidx(.@i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to dastgir idea, that just push another array of the index,
that means this example has to change accordingly

Suggested change
equipidx(.@i);
equipidx(@inventorylist_idx[.@i]);

break;
}
}

---------------------------------------

*buyingstore(<slots>)

Invokes buying store preparation window like the skill 'Open Buying
Expand Down
66 changes: 58 additions & 8 deletions src/map/script.c
Original file line number Diff line number Diff line change
Expand Up @@ -16473,21 +16473,28 @@ static BUILDIN(unequip)

static BUILDIN(equip)
{
int nameid=0,i;
int nameid = 0, i;
struct item_data *item_data;
struct map_session_data *sd = script->rid2sd(st);
if (sd == NULL)
return false;

nameid=script_getnum(st,2);
if((item_data = itemdb->exists(nameid)) == NULL)
{
ShowError("wrong item ID : equipitem(%d)\n",nameid);
if (sd == NULL) {
script_pushint(st, 0);
return true;
}

nameid = script_getnum(st, 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nameid can be defined here
int nameid = script_getnum(st, 2);

if ((item_data = itemdb->exists(nameid)) == NULL) {
ShowError("buildin_equip: Invalid Item ID (%d).\n", nameid);
script_pushint(st, 0);
return false;
}

ARR_FIND(0, sd->status.inventorySize, i, sd->status.inventory[i].nameid == nameid && sd->status.inventory[i].equip == 0);

if (i < sd->status.inventorySize)
pc->equipitem(sd, i, item_data->equip);
script_pushint(st, pc->equipitem(sd, i, item_data->equip));
else
script_pushint(st, 0);

return true;
}
Expand Down Expand Up @@ -16515,6 +16522,48 @@ static BUILDIN(autoequip)
return true;
}

/**
* equipidx(<index>)
*/
static BUILDIN(equipidx)
{
struct map_session_data *sd = script->rid2sd(st);

if (sd == NULL) {
script_pushint(st, 0);
return true;
}

int i = script_getnum(st, 2);
if (i < 0 || i >= sd->status.inventorySize) {
ShowError("buildin_equipidx: Index (%d) should be from 0-%d.\n", i, sd->status.inventorySize - 1);
script_pushint(st, 0);
return false;
}

if (sd->status.inventory[i].equip != 0) { // item already equipped, run silently
script_pushint(st, 1);
return true;
}

int nameid = sd->status.inventory[i].nameid;
struct item_data *item_data = itemdb->exists(nameid);
if (item_data == NULL) {
ShowError("buildin_equipidx: Invalid Item ID (%d).\n", nameid);
script_pushint(st, 0);
return false;
}

if (pc->equipitem(sd, i, item_data->equip) == 0) {
ShowWarning("buildin_equipidx: Item ID (%d) at index (%d) cannot be equipped.\n", nameid, i);
script_pushint(st, 0);
return false;
}

script_pushint(st, 1);
return true;
}

/*=======================================================
* Equip2
* equip2 <item id>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>;
Expand Down Expand Up @@ -25491,6 +25540,7 @@ static void script_parse_builtin(void)
BUILDIN_DEF(equip,"i"),
BUILDIN_DEF(autoequip,"ii"),
BUILDIN_DEF(equip2,"iiiiiii"),
BUILDIN_DEF(equipidx, "i?"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BUILDIN_DEF(equipidx, "i?"),
BUILDIN_DEF(equipidx, "i"),

didnt have optional parameter.

BUILDIN_DEF(setbattleflag,"si"),
BUILDIN_DEF(getbattleflag,"s"),
BUILDIN_DEF(setitemscript,"is?"), //Set NEW item bonus script. Lupus
Expand Down