Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @who4 command (excludes vendors from @who list). #2288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bWolfie
Copy link
Contributor

@bWolfie bWolfie commented Oct 16, 2018

Pull Request Prelude

Changes Proposed

Adds the @who4 command. Same as regular @who, but excludes vendors from the list.

Affected Branches:

  • master
  • stable

Issues addressed:

N/A

Known Issues and TODO List

N/A

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@dastgirp
Copy link
Member

Wouldn't it be better if we have one command and add first argument for deciding these things?

@bWolfie
Copy link
Contributor Author

bWolfie commented Oct 16, 2018

You mean redesigning command?

@Emistry
Copy link
Member

Emistry commented Oct 16, 2018

ex:enable criteria to exclude from the list.
btw, instead the exclude vendors... perhaps make it exclude player who are afk, that way we could pretty much auto excluded all vendors by default

@Cyanide0210
Copy link
Contributor

Yeah we could add arguments like "map" and things like that, which actually can replace @whomap also

@4144
Copy link
Contributor

4144 commented Oct 26, 2018

probably better convert all this @whoN into one @who command with bit field parameter for include or exclude each type of players

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants