Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/python data #46

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Dev/python data #46

merged 14 commits into from
Jan 23, 2024

Conversation

austinschneider
Copy link
Collaborator

This PR aims to improve how we are packaging our data.

The main goals are:

  • Have the package reference data from its resources directory
  • Store generated data from DarkNews in the resources directory
  • Version the cross sections, detector models, etc.
  • Create a system for managing versions of these models in the context of the LIController and any other methods that perform some sort of automatic/default setup procedure

@austinschneider austinschneider self-assigned this Jan 22, 2024
@austinschneider austinschneider added the enhancement New feature or request label Jan 22, 2024
@austinschneider austinschneider changed the base branch from dev/coordinate_transforms to main January 22, 2024 23:43
@austinschneider austinschneider marked this pull request as ready for review January 22, 2024 23:55
@austinschneider
Copy link
Collaborator Author

Currently this PR just fixes the python files within the project to use relative imports for things inside the package, adds some utilities for locating package resources, and installs resources into the python wheel.

@nickkamp1
Copy link
Collaborator

Currently this PR just fixes the python files within the project to use relative imports for things inside the package, adds some utilities for locating package resources, and installs resources into the python wheel.

Sounds good. Just verifying that I can run each example locally. So we'll have a separate branch for versioning?

Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples are able to run locally. Approving PR

@austinschneider austinschneider merged commit d89559c into main Jan 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants