Rename earth_model to detector_model

[austinschneider]

Just realized we forgot to rename these variables in the previous PR

[nickkamp1]

looks good, just need to change the earthparams directory to DetectorParams. I will do this in ~30 min after biking into work :)

[austinschneider]

Looks like there are a few other places that "earth" pops in that we might want to rename.

[austinschneider]

There is also a file in math called Coordinates.cxx that we can delete.

[nickkamp1]

Looks like there are a few other places that "earth" pops in that we might want to rename.

Yeah, for example functions like GetDetCoordPosFromEarthCoordPos should probably be renamed, but it might make sense to do that on the coordinate transformation branch?

[austinschneider]

Finally, something is causing the build to fail pretty early on in the GitHub runners. We should fix that too.

[nickkamp1]

There is also a file in math called Coordinates.cxx that we can delete.

I agree it seems to be legacy. But I think we should delete it in the coordinate transformation branch?

[nickkamp1]

Looks like there are a few other places that "earth" pops in that we might want to rename.

Yeah, for example functions like GetDetCoordPosFromEarthCoordPos should probably be renamed, but it might make sense to do that on the coordinate transformation branch?

Ok I actually went back and renamed every earth -> detector instance that doesn't interface with DetectorModel::GetEarthCoordPosFromDetCoordPos, since I think we should rename that function based on the updates in the coordinate transformation branch

[nickkamp1]

Finally, something is causing the build to fail pretty early on in the GitHub runners. We should fix that too.

I think this is the last remaining issue on this branch before we can merge

[austinschneider]

Cool, yeah I'll make those changes in the coordinate transformation branch 👍

[austinschneider]

These latest cmake changes allowed one of the linux builds to work. We'll see if this extends to the rest of the builds invoked by cibuildwheel 🤞

[austinschneider]

The linux builds seem to be going just fine now, but the macos builds are still stuck on the delocate stage. It seems like it is complaining that it cannot find python. If it is trying to package the python shared object library into the wheel, then we could stop it from doing so with --ignore-missing-dependencies, but it may actually need this. In any case, it is strange that we're getting this error. It is complaining that /Library/Frameworks/Python.framework/Versions/3.8/Python is not found, but this file does exist and is the correct python library.

[austinschneider]

Okay, we're still getting the same error on cd2f3a4. I forgot that the Development.Module was conditional on cibuildwheel, so trying the combination of Development.Module and pybind11::python_link_helper on my local machine actually has the same linking error with python.

[austinschneider]

At least one of the macos builds is finishing now!

[nickkamp1]

At least one of the macos builds is finishing now!

awesome thanks Austin!!

[austinschneider]

@nickkamp1 we can go ahead and merge this once you have a chance to look things over!

[nickkamp1]

Looks good, merge approved! Thanks for getting the ci build working Austin