Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.8.0] Create Dynamic Columns from Dynamic Data & Form Field Fixes #420

Merged
merged 18 commits into from
Nov 20, 2024
Merged

[v4.8.0] Create Dynamic Columns from Dynamic Data & Form Field Fixes #420

merged 18 commits into from
Nov 20, 2024

Conversation

BboyAkers
Copy link
Member

@BboyAkers BboyAkers commented Nov 18, 2024 •
edited
Loading

Overview:

@BboyAkers
added dynamic attributes to the orderedColumns
4608737
@BboyAkers
inital commit for displaying dynamic table columns with disabled sorting
7e0a23f
@BboyAkers
removed console logs
c61679a
@BboyAkers
added max length to input fields
b21cf17
@BboyAkers
removed pseudo code
866612c
@BboyAkers
disabled dynamically added rows
229536f
@BboyAkers
Merge pull request #417 from HarperDB/aakers/max-length-fix
9559592 
[Enhancement] Added Max Length to necessary Input Fields on Sign Up Page
@BboyAkers
only return attributes that are used 8 times or more in the getAttrib…
d3ed026 
…utesFromTableData()
@BboyAkers
Merge pull request #416 from HarperDB/aakers/STUDIO-110
2e8853d 
[Enhancement] Added Dynamically Defined Keys in Rows as Table Columns
@BboyAkers
Merge pull request #419 from HarperDB/4.8.0
afac7fb 
[v4.8.0] Create Dynamic Columns from Dynamic Data & Form Field Fixes
@BboyAkers
version update to 4.8.0
dd0eef4
@BboyAkers BboyAkers added bug Something isn't working enhancement New feature or request a11y Accessibility labels Nov 18, 2024
kriszyp
kriszyp requested changes Nov 18, 2024
View reviewed changes
src/components/auth/SignUp.js Outdated Show resolved Hide resolved
src/functions/instance/getTableData.js Outdated Show resolved Hide resolved
@kriszyp
Copy link
Member

kriszyp commented Nov 18, 2024

I think you should be able request reviews by adding reviewers in Github rather than slack?

@BboyAkers BboyAkers requested a review from kriszyp November 18, 2024 22:31
@BboyAkers
Copy link
Member Author

@kriszyp ready for another round of reviews 🙂

kriszyp
kriszyp approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BboyAkers BboyAkers merged commit 3add1b7 into master Nov 20, 2024
2 checks passed
@BboyAkers BboyAkers mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidCockerill DavidCockerill DavidCockerill approved these changes

@kriszyp kriszyp kriszyp approved these changes

Assignees
No one assigned
Labels
a11y Accessibility bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BboyAkers @kriszyp @DavidCockerill