Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce package size by copying correct native dlls #141

Closed
wants to merge 1 commit into from

Conversation

saskathex
Copy link

To reduce the final package size copy include the native dlls as following:

  • "AnyCPU" copy both native dlls (x86, x64)
  • "x64" copy only x64 native dll
  • "x86" copy only x86 native dll

@saskathex saskathex closed this Jan 15, 2025
@HakanL
Copy link
Owner

HakanL commented Jan 15, 2025

Did you look at the generated nuget package? I would actually expect the output size to be the same, since it's built for both architectures.

@saskathex
Copy link
Author

Yes you are correct, the package has the same size. What I more meant is when building the final release lets say x64, then the x64 runtime dll is only copied to the final build. So package size should have been called "final release build".

I closed the pull request, since it did not work the expected way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants