Breaking API Change: reorganize Carthage directory structure #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major incompatible change to the existing output of Carthage, and to the API for organizing that output: * New directory cache_dir, similar to output_dir, for things like stamps and processed mako files that can be recreated. * state_dir is clearly documented for things that are hard to reproduce. * New log_dir * output_dir removed from config * New PathMixin that provides stamp_path, state_path, and log_path based on stamp_subdir. * SetupTaskMixin is a PathMixin * Refactor to set stamp_subdir everywhere. * ContainerVolumes and ImageVolumes no longer store their stamps within the volume. As a result, clear out stamps when volumes are created. * To do that introduce clear_stamps_and_cache to PathMixin
Now that container stamps no longer live in containers, bringing a container to ready from ansible_chroot_helper will try to regenerate the ssh key. But the container is already running so this fails. We never want ansible_chroot_helper to run setup_tasks because it does not have enough Carthage config to do so safely. So never bring the container to ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create three classes of directories off PathMixin including SetupTaskMixin
All these sub directories have the same structure based off
stamp_subdir.PathMixin also always has a config_layout, which never drops a ConfigLayout into the injector.