Map MS partof to RO #232
Map MS partof to RO #232
Conversation
| @@ -45,6 +45,7 @@ name: has_units | |||
| [Typedef] | |||
| id: part_of | |||
| name: part_of | |||
| xref: BFO:0000050 | |||
There was a problem hiding this comment.
@matentzn Can you update the version of the ontology. See the failing Actions https://github.com/HUPO-PSI/psi-ms-CV/actions/runs/7638645173/job/20810093289
There was a problem hiding this comment.
Feel free to close this PR and redo it, I just wanted to show you how you can map your part of to RO, so it displays correctly in OLS and interoperates with other ontologies. You can also directly edit my PR and make the required changes!
There was a problem hiding this comment.
Done. Thanks a lot for the tip.
|
I merged the PR to see the changes and opened the owl created in Protege as suggested; and it looks for me that the problem still remains
Any advice @matentzn ? |
|
This is a weakness in Protege I think. If you look at the peptide classes, you can see peptide attribute underneath, with the blue arrow..
Lets see how Protege will display this.. |
|
(I think the problem in Protege is that it will include the is a hierarchy no matter what, and superimposes the other "relation ships" after the fact - which means that what you see in terms of top level roots are all the roots according to the is a hierarchy) |
Fixes EBISPOT/ols4#600
Ideally, in a future PR, you should consider to import RO rather than copy pasting the semantics here (i.e. transitivity).