Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 2020 methodology for Traditional Chinese #1809

Merged
merged 6 commits into from
Dec 21, 2020
Merged

Conversation

AbbyTsai
Copy link
Contributor

progress #1106

@HTTPArchive/traditional-chinese-translators
Happy to hear all your thoughts for review. Thanks.

@tunetheweb tunetheweb requested a review from a team December 19, 2020 18:12
@tunetheweb tunetheweb added the translation world wide web label Dec 19, 2020
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 19, 2020
Copy link
Contributor

@CYBAI CYBAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a very quick review! 🙇

src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few links have got spaces in them now. Could you do a search cor > and > to try to identify them all? I've pointed out a few examples but not pointed them all out.

Also try to use hreflang on links when you can.

src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These spaces shouldn't be in the links. Though can add outside the links if you want?

By the way, you can use the "Add suggestions to Batch" option in the Files tab and then commit these at once, as quicker than doing them one by one.

<h2 id="dataset"><a href="#dataset" class="anchor-link">關於資料集</a></h2>

<p>
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery </a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this extra space as part of the link?

Suggested change
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery </a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery</a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a copywriting guidance warm sharing from CYBAI suggests that it's better to put a space between mix language in Chinese and English, and don't leave a space if there is the punctuation next to them. Then the space's going to move outside the link. thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then, yeah I think space outside the link is better. Unless you or @CYBAI disagree?

src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
<h2 id="dataset"><a href="#dataset" class="anchor-link">關於資料集</a></h2>

<p>
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery </a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a copywriting guidance warm sharing from CYBAI suggests that it's better to put a space between mix language in Chinese and English, and don't leave a space if there is the punctuation next to them. Then the space's going to move outside the link. thanks.

src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/zh-TW/2020/methodology.html Outdated Show resolved Hide resolved
make a space outside the links.

Co-authored-by: Barry Pollard <[email protected]>
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me know if ready to merge or if you're still working on any other issues.

@AbbyTsai
Copy link
Contributor Author

ready to go, thanks.

@tunetheweb tunetheweb merged commit e269518 into main Dec 21, 2020
@tunetheweb tunetheweb deleted the trad_chinese_meth branch December 21, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants