-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate 2020 methodology for Traditional Chinese #1809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a very quick review! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a few links have got spaces in them now. Could you do a search cor >
and >
to try to identify them all? I've pointed out a few examples but not pointed them all out.
Also try to use hreflang
on links when you can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These spaces shouldn't be in the links. Though can add outside the links if you want?
By the way, you can use the "Add suggestions to Batch" option in the Files tab and then commit these at once, as quicker than doing them one by one.
<h2 id="dataset"><a href="#dataset" class="anchor-link">關於資料集</a></h2> | ||
|
||
<p> | ||
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery </a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this extra space as part of the link?
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery </a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>。 | |
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery</a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a copywriting guidance warm sharing from CYBAI suggests that it's better to put a space between mix language in Chinese and English, and don't leave a space if there is the punctuation next to them. Then the space's going to move outside the link. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK then, yeah I think space outside the link is better. Unless you or @CYBAI disagree?
<h2 id="dataset"><a href="#dataset" class="anchor-link">關於資料集</a></h2> | ||
|
||
<p> | ||
HTTP Archive 資料集每月持續更新數據,除各章節另有說明外,2020年版所有指標都來自2020年8月。這些結果可以透過<a hreflang="en" href="https://github.com/HTTPArchive/httparchive.org/blob/master/docs/gettingstarted_bigquery.md">設置 BigQuery </a>公共資料集的相關日期探索查詢,例如<code>2020_08_01</code>。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a copywriting guidance warm sharing from CYBAI suggests that it's better to put a space between mix language in Chinese and English, and don't leave a space if there is the punctuation next to them. Then the space's going to move outside the link. thanks.
make a space outside the links. Co-authored-by: Barry Pollard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let me know if ready to merge or if you're still working on any other issues.
ready to go, thanks. |
progress #1106
@HTTPArchive/traditional-chinese-translators
Happy to hear all your thoughts for review. Thanks.