Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dutch base templates #1767

Merged
merged 35 commits into from
Dec 15, 2020
Merged

Added Dutch base templates #1767

merged 35 commits into from
Dec 15, 2020

Conversation

strangernr7
Copy link
Contributor

@strangernr7 strangernr7 commented Dec 15, 2020 •
edited
Loading

Makes progress on #1750

@strangernr7 strangernr7 changed the title Makes progress on #1750 Added dutch template folder Dec 15, 2020
@strangernr7 strangernr7 added the translation world wide web label Dec 15, 2020
tunetheweb
tunetheweb requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes allow the site to run. Will do a more thorough review later.

src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
src/server/language.py Outdated Show resolved Hide resolved
src/templates/nl/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/base.html Outdated Show resolved Hide resolved
src/templates/nl/base.html Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 15, 2020
tunetheweb
tunetheweb requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more!

src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
@strangernr7
Copy link
Contributor Author

Unfortunately there's a lot of these little errors. I'll make sure this doesn't happen on the markdown files

@tunetheweb tunetheweb changed the title Added dutch template folder Added Dutch base templates Dec 15, 2020
tunetheweb
tunetheweb requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic @noah-vdv !

Once we get these last few corrections in, I think this is good to merge!

src/templates/nl/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/base.html Outdated Show resolved Hide resolved
src/templates/nl/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/accessibility_statement.html Outdated Show resolved Hide resolved
src/templates/nl/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
@tunetheweb
Copy link
Member

Ok and one more thing. Could you add yourself to the contributors section of config/2019.json and config/2020.json in the translators team so you appear on our Contributors page? It's alphabetical by first name.

strangernr7 and others added 8 commits December 15, 2020 15:37
tunetheweb
tunetheweb reviewed Dec 15, 2020
View reviewed changes
src/config/2019.json Outdated Show resolved Hide resolved
src/config/2020.json Outdated Show resolved Hide resolved
@strangernr7
Copy link
Contributor Author

Alright, I'll go check both methodology files for dutch language mishaps and then I think it's good to go if you guys don't have anythig else to add

@tunetheweb
Copy link
Member

Cool. Take it out of draft when you're happy to merge.

Are you able to run this locally? Or want me to put up a test site for you to review?

@tunetheweb
Copy link
Member

tunetheweb commented Dec 15, 2020 •
edited
Loading

I put up a test version here: https://20201215t151713-dot-webalmanac.uk.r.appspot.com/nl/2020/

@strangernr7
Copy link
Contributor Author

Oh yeah, awesome thx

tunetheweb
tunetheweb reviewed Dec 15, 2020
View reviewed changes
src/config/2019.json Show resolved Hide resolved
src/config/2020.json Show resolved Hide resolved
tunetheweb
tunetheweb requested changes Dec 15, 2020
View reviewed changes
src/templates/nl/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/nl/2020/methodology.html Outdated Show resolved Hide resolved
@strangernr7 strangernr7 marked this pull request as ready for review December 15, 2020 16:56
tunetheweb
tunetheweb approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this. Will get it released soon.

But let’s do a smaller PR next time with just one chapter at a time though! 😁

@tunetheweb tunetheweb merged commit e44cbe9 into HTTPArchive:main Dec 15, 2020
@strangernr7
Copy link
Contributor Author

LGTM! Thanks for this. Will get it released soon.

But let’s do a smaller PR next time with just one chapter at a time though! 😁

😄 Yes definitely. With the md files I'll do them separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
2020 Content Translation
Development

Successfully merging this pull request may close these issues.
2 participants
@strangernr7 @tunetheweb