Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of base.html to Hindi #1458

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Translation of base.html to Hindi #1458

merged 2 commits into from
Nov 9, 2020

Conversation

PraveenPal4232
Copy link
Contributor

@PraveenPal4232 PraveenPal4232 commented Nov 9, 2020 •
edited
Loading

Translation of base.html 2019 to Hindi
For issue #1402

@PraveenPal4232 PraveenPal4232 added the translation world wide web label Nov 9, 2020
tunetheweb
tunetheweb requested changes Nov 9, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! A few things I spotted though.

Also if you merge latest main into this branch then that will solve the code errors being highlighted (they are completely unrelated to your changes in case you were worried!)

src/templates/hi/2019/base.html Outdated Show resolved Hide resolved
src/templates/hi/2019/base.html Outdated Show resolved Hide resolved
src/templates/hi/2019/base.html Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Nov 9, 2020
tunetheweb
tunetheweb approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let me know if you're happy for me to merge or are still adding changes?

@PraveenPal4232
Copy link
Contributor Author

LGTM - let me know if you're happy for me to merge or are still adding changes?

Of course, please do that. I am done. Thank

@tunetheweb tunetheweb merged commit 48e11b9 into HTTPArchive:main Nov 9, 2020
@tunetheweb
Copy link
Member

Done. Thank you for this contribution!

That base.html is a tricky one as includes lots of snippets and macros used by the site. It's a key one though so good to get it done.

Looking forward to getting the rest of the core templates so we can more on to the more interesting chapters!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@PraveenPal4232 @tunetheweb